Skip to content

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Jan 6, 2026

as title.

As an experiment, I setup a sub workflow for the install flutter. If this works, I will push another pr to update the release workflow to use the sub workflow

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@gemini-code-assist
Copy link

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one change.

shell: bash
run: |
cd $HOME
git clone https://github.com/flutter/flutter.git --depth 1 -b 3.38.1 _flutter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the goal to require the version to be shared? If not, we should make this an input.

If so, it needs to be 3.38.5, as I'm rolling it in #10722, and it's important that we not accidentally move backward or releasing that package will stop working.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like it to be shared for now, having different flutter version for different workflow seems like a code smell. We can revisit later if we have use cases for that.

will update to 3.38.5

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 7, 2026
@auto-submit auto-submit bot merged commit 9705815 into flutter:main Jan 7, 2026
81 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 7, 2026
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jan 7, 2026
flutter/packages@d3f860d...9705815

2026-01-07 [email protected] [ci] setup flutter
in batch release workflow (flutter/packages#10735)
2026-01-07 [email protected] [mustache_template] Improve error
throwing (flutter/packages#10700)
2026-01-06 [email protected] [ci] Adjust
workflow for dispatching go_router batch release
(flutter/packages#10733)
2026-01-06 [email protected] [rfw] Remove
scripting language integration section from `README`
(flutter/packages#10726)
2026-01-06 [email protected] [image_picker] Update for UIScene
compatibility (flutter/packages#10677)
2026-01-06 [email protected] [google_maps_flutter] Add iOS SDK
10.x support (flutter/packages#10720)
2026-01-06 [email protected] Update Google Fonts
to v7.0.0 with new and removed fonts (flutter/packages#10713)
2026-01-06 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump the kotlin-gradle-plugin group across 7 directories
with 1 update (flutter/packages#10661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jan 7, 2026
flutter/packages@d3f860d...9705815

2026-01-07 [email protected] [ci] setup flutter
in batch release workflow (flutter/packages#10735)
2026-01-07 [email protected] [mustache_template] Improve error
throwing (flutter/packages#10700)
2026-01-06 [email protected] [ci] Adjust
workflow for dispatching go_router batch release
(flutter/packages#10733)
2026-01-06 [email protected] [rfw] Remove
scripting language integration section from `README`
(flutter/packages#10726)
2026-01-06 [email protected] [image_picker] Update for UIScene
compatibility (flutter/packages#10677)
2026-01-06 [email protected] [google_maps_flutter] Add iOS SDK
10.x support (flutter/packages#10720)
2026-01-06 [email protected] Update Google Fonts
to v7.0.0 with new and removed fonts (flutter/packages#10713)
2026-01-06 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump the kotlin-gradle-plugin group across 7 directories
with 1 update (flutter/packages#10661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants