Skip to content

Conversation

@jesswrd
Copy link
Contributor

@jesswrd jesswrd commented Nov 12, 2025

Add kgp to plugins bulk update dependency tooling.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds functionality to the dependency update tool to support bulk updates for the Android Gradle Plugin (AGP) and Kotlin Gradle Plugin (KGP). This is achieved by adding new dependency types, corresponding version validation logic, and file update mechanisms targeting settings.gradle. The PR also includes comprehensive tests for the new functionality.

My review includes two main points for improvement in script/tool/lib/src/update_dependency_command.dart:

  1. Refactoring duplicated code for handling AGP and KGP updates to improve maintainability.
  2. Making the version validation regex for KGP more flexible to support future versioning schemes, such as minor versions with two digits (e.g., 1.10.0) or pre-release tags.

@jesswrd jesswrd requested a review from a team November 14, 2025 01:14
output,
containsAllInOrder(<Matcher>[
contains('''
A version with a valid format (3 numbers separated by 2 periods) must be provided.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you extract this out into a constant that is referenced here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants