Conversation
stream_transform is more commonly used internally and is also owned by Google.
There was a problem hiding this comment.
Code Review
This pull request replaces the rxdart dependency with stream_transform and introduces a custom combineLatestAll extension for stream handling. The feedback suggests utilizing the built-in combineLatestList function from the stream_transform package instead of the custom extension, which would simplify the implementation and allow for the removal of the newly added utility file.
|
@polina-c would you have any suggestions on how to resolve the layerlens failure here? (included the mermaid diagram below). It looks like we're checking for cycles between directories. Currently, flowchart TD;
catalog-->functions;
catalog-->model;
catalog-->primitives;
catalog-->utils;
catalog-->widgets;
development_utilities-->engine;
development_utilities-->model;
development_utilities-->primitives;
development_utilities-->widgets;
engine-->interfaces;
engine-->model;
engine-->primitives;
facade-->engine;
facade-->interfaces;
facade-->model;
facade-->primitives;
functions-->model;
functions-->primitives;
functions-->utils;
interfaces-->model;
model--!-->utils;
model-->primitives;
transport-->interfaces;
transport-->model;
utils-->model;
utils-->primitives;
utils-->widgets;
widgets-->interfaces;
widgets-->model;
widgets-->primitives;
|
True. The tool watches for cycles between items in a directory, that are child directories and child files, without differentiating between them. It assumes that we organize code by files and directories having our mental model in mind and "helps" to keep this mental model clean and simple. One option to resolve this loop is to declare folders 'utils' and 'helpers', where 'utils' are low level and should not depend on 'model', and helpers are higher level and can depend on model. Another option is to move validation_helper.dart to 'model', because this helper seems to help to deal with the model. And, there can be other ways that I did not notice. Does it answer your question? |
stream_transform is more commonly used internally and is also owned by Google.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.