Skip to content

Fix DaemonCrashReporter dialog modality type #8066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

pq
Copy link
Contributor

@pq pq commented Apr 16, 2025

The constructor we were invoking was defaulting to IdeModalityType.PROJECT which is not fully supported. Migrating to use IdeModalityType.IDE addresses this.

(Verified on Meerkat.)

Fixes: #7986

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@pq pq requested a review from jwren April 16, 2025 16:51
@jwren jwren merged commit 62d4d2d into flutter:master Apr 16, 2025
9 checks passed
@pq pq deleted the bug_DeviceDaemonDialog_modality branch April 16, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants