Skip to content

Add comments to identify current risk from the Components deprecation #6954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Add comments to identify current risk from the Components deprecation #6954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions flutter-idea/src/io/flutter/font/ProjectOpenListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,15 @@
import org.jetbrains.annotations.NotNull;

public class ProjectOpenListener implements ProjectManagerListener {
//See https://plugins.jetbrains.com/docs/intellij/plugin-components.html#comintellijpoststartupactivity
// for notice and documentation on the deprecation intentions of
// Components from JetBrains.
//
// Migration forward has different directions before and after
// 2023.1, if we can, it would be prudent to wait until we are
// only supporting this major platform as a minimum version.
//
// https://github.com/flutter/flutter-intellij/issues/6953
@Override
public void projectOpened(@NotNull Project project) {
// Ensure this isn't part of testing
Expand Down
9 changes: 9 additions & 0 deletions flutter-idea/src/io/flutter/project/FlutterProjectStructureDetector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,15 @@ private void scheduleAndroidModuleAddition(@NotNull String projectName, @NotNull
scheduleDisconnectIfCancelled(connection);
//noinspection ConstantConditions
connection[0].subscribe(ProjectManager.TOPIC, new ProjectManagerListener() {
//See https://plugins.jetbrains.com/docs/intellij/plugin-components.html#comintellijpoststartupactivity
// for notice and documentation on the deprecation intentions of
// Components from JetBrains.
//
// Migration forward has different directions before and after
// 2023.1, if we can, it would be prudent to wait until we are
// only supporting this major platform as a minimum version.
//
// https://github.com/flutter/flutter-intellij/issues/6953
@Override
public void projectOpened(@NotNull Project project) {
if (connection[0] != null) {
Expand Down
9 changes: 9 additions & 0 deletions flutter-idea/src/io/flutter/sdk/FlutterSdkManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,15 @@ private FlutterSdkManager(@NotNull Project project) {
});

ProjectManager.getInstance().addProjectManagerListener(myProject, new ProjectManagerListener() {
//See https://plugins.jetbrains.com/docs/intellij/plugin-components.html#comintellijpoststartupactivity
// for notice and documentation on the deprecation intentions of
// Components from JetBrains.
//
// Migration forward has different directions before and after
// 2023.1, if we can, it would be prudent to wait until we are
// only supporting this major platform as a minimum version.
//
// https://github.com/flutter/flutter-intellij/issues/6953
@Override
public void projectOpened(@NotNull Project project) {
checkForFlutterSdkChange();
Expand Down