Skip to content

Evaluate how we're using flutter outline information to calculate test line markers #7991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pq opened this issue Apr 3, 2025 · 1 comment
Open

Evaluate how we're using flutter outline information to calculate test line markers #7991

pq opened this issue Apr 3, 2025 · 1 comment
Labels
investigate P2 performance General performance issues (not perf tool) tech debt topic-testing

Comments

@pq
Copy link
Contributor

pq commented Apr 3, 2025

Follow-up from #7980.

We no longer show a flutter outline view but take advantage of flutter outline information to calculate test line markers. Is this the best approach?
@pq pq added investigate performance General performance issues (not perf tool) tech debt topic-testing P2 labels Apr 3, 2025
@pq
Copy link
Contributor Author

pq commented Apr 3, 2025

fyi @bwilkerson, as this fits into a more general theme of assessing legacy protocol dependence and use.

@pq pq mentioned this issue Apr 8, 2025
Merged
8 tasks
jwren pushed a commit that referenced this issue Apr 9, 2025
@pq
[CQ] remove unused OutlineOffsetConverter (#8023)
6b27f6d 
Removing this gets rid of one more (unused) reference to the
`FlutterOutlineView` and will allow us to better evaluate if we can stop
using the `flutter.outline` protocol (see: #7991).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
investigate P2 performance General performance issues (not perf tool) tech debt topic-testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pq