Store buildNumber in presubmitJob on inProgress event

[ievdokdm]

Store buildNumber in presubmitJob on inProgress event

Fix: flutter/flutter#184371

[github-actions]

🤖 Hi @ievdokdm, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

[github-actions]

## 📋 Review Summary

This pull request correctly adds the storage of the buildNumber in the presubmitJob record during the inProgress state. This ensures that the build number is available for monitoring or debugging purposes as soon as the build starts.

🔍 General Feedback

• The change is surgical and consistent with the existing logic for handling job completion.
• I've suggested adding a unit test to verify this behavior and prevent regressions in the future.
• The use of state.buildNumber is safe because the PresubmitJob.buildNumber setter correctly handles nullable integers.

[github-actions]

🟢 It would be beneficial to add a unit test to verify that the buildNumber is correctly updated when the task status is inProgress. This ensures that any future changes to this logic don't accidentally drop the build number at this stage.

For example, you could add a test case in app_dart/test/service/firestore/unified_check_run_test.dart:

      test('updates check status and build number on inProgress', () async {
        final state = const PresubmitJobState(
          jobName: 'linux',
          status: TaskStatus.inProgress,
          attemptNumber: 1,
          startTime: 2000,
          buildNumber: 456,
        );

        final result = await UnifiedCheckRun.markConclusion(
          firestoreService: firestoreService,
          guardId: guardId,
          state: state,
        );

        expect(result.result, PresubmitGuardConclusionResult.ok);

        final checkDoc = await PresubmitJob.fromFirestore(
          firestoreService,
          PresubmitJobId(
            slug: slug,
            checkRunId: 123,
            jobName: 'linux',
            attemptNumber: 1,
          ),
        );
        expect(checkDoc.status, TaskStatus.inProgress);
        expect(checkDoc.startTime, 2000);
        expect(checkDoc.buildNumber, 456);
      });

[eyebrowsoffire]

This is a good idea