Skip to content

fix: persist 'ws_uri' in _saveSettings to enable proper registration #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: persist 'ws_uri' in _saveSettings to enable proper registration #542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions example/lib/src/register.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,13 @@ class _MyRegisterWidget extends State<RegisterWidget>
_saveSettings();

currentUser.register(SipUser(
wsUrl: _wsUriController.text,
//this is the websocket url which was missing in the original code hence it
//was showing null in the register method of sip_user_cubit.dart and always
//redirected to 'wss://tryit.jssip.net:10443', present inside sip_ua_helper.dart
//161: uaSettings.webSocketUrl ?? 'wss://tryit.jssip.net:10443',
//this will help people trying out the example to register with the correct url
//without changing the code in sip_ua_helper.dart
selectedTransport: _selectedTransport,
wsExtraHeaders: _wsExtraHeaders,
sipUri: _sipUriController.text,
Expand Down