Repository navigation
chore(deps): bump github.com/prometheus/client_golang from 1.20.5 to 1.25.0 - #6230
Open
dependabot[bot] wants to merge 1 commit into
Open
dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
dependencies
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Linux builds with the appengine tag fail due to a missing helper, and DiscardUnknown bypasses the recursion limit, leaving deeply nested unknown input vulnerable to unbounded stack growth.
No open issues 🎉
What changed in this PR
Updates Fluid’s vendored Prometheus client for client_golang v1.25.0, including related dependency refreshes.
Changes:
- Updates metric construction, unit support, HTTP instrumentation, and platform-specific process collectors.
- Refreshes protobuf parsing, procfs utilities, and Go tooling, networking, Unicode, and terminal dependencies.
- Removes compression implementation files as zstd support becomes optional.
| File | Description |
|---|---|
| vendor/google.golang.org/protobuf/types/known/timestamppb/timestamp.pb.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/reflect/protoreflect/source_gen.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/reflect/protodesc/desc_init.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/version/version.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/genid/descriptor_gen.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/encoding/defval/default.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/encoding/prototext/decode.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/encoding/protojson/well_known_types.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/encoding/protojson/decode.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/encoding/protodelim/protodelim.go | Updated as part of this pull request. |
| vendor/golang.org/x/tools/internal/typesinternal/types.go | Updated as part of this pull request. |
| vendor/golang.org/x/tools/internal/typeparams/common.go | Updated as part of this pull request. |
| vendor/golang.org/x/tools/go/types/typeutil/ui.go | Updated as part of this pull request. |
| vendor/golang.org/x/tools/go/types/typeutil/methodsetcache.go | Updated as part of this pull request. |
| vendor/golang.org/x/tools/go/types/typeutil/imports.go | Updated as part of this pull request. |
| vendor/golang.org/x/tools/go/packages/visit.go | Updated as part of this pull request. |
| vendor/golang.org/x/tools/go/ast/inspector/cursor.go | Updated as part of this pull request. |
| vendor/golang.org/x/text/unicode/norm/transform.go | Updated as part of this pull request. |
| vendor/golang.org/x/text/unicode/norm/normalize.go | Updated as part of this pull request. |
| vendor/golang.org/x/text/unicode/norm/forminfo.go | Updated as part of this pull request. |
| vendor/golang.org/x/text/unicode/bidi/core.go | Updated as part of this pull request. |
| vendor/golang.org/x/text/encoding/japanese/iso2022jp.go | Updated as part of this pull request. |
| vendor/golang.org/x/term/terminal.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/windows/types_windows.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_linux_sparc64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_linux_s390x.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_linux_riscv64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_linux_ppc64le.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_linux_ppc64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_linux_ppc.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_linux_mipsle.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_linux_mips64le.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_linux_mips64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_linux_mips.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_linux_loong64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_linux_arm64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_linux_arm.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_linux_amd64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_linux_386.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_linux.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_linux_s390x.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_linux_riscv64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_linux_ppc64le.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_linux_ppc64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_linux_ppc.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_linux_mipsle.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_linux_mips64le.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_linux_mips64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_linux_mips.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_linux_loong64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_linux_arm64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_linux_arm.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_linux_amd64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_linux_386.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_linux.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_bsd.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/mkerrors.sh | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ioctl_linux.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ifreq_linux.go | Updated as part of this pull request. |
| vendor/golang.org/x/net/trace/histogram.go | Updated as part of this pull request. |
| vendor/golang.org/x/net/internal/httpcommon/README.md | Updated as part of this pull request. |
| vendor/golang.org/x/net/http2/transport.go | Updated as part of this pull request. |
| vendor/golang.org/x/net/http2/transport_wrap.go | Updated as part of this pull request. |
| vendor/golang.org/x/net/http2/databuffer.go | Updated as part of this pull request. |
| vendor/golang.org/x/net/http2/ascii.go | Updated as part of this pull request. |
| vendor/golang.org/x/net/html/escape.go | Updated as part of this pull request. |
| vendor/github.com/stretchr/testify/require/requirements.go | Updated as part of this pull request. |
| vendor/github.com/stretchr/testify/require/require.go.tmpl | Updated as part of this pull request. |
| vendor/github.com/stretchr/testify/require/require_forward.go.tmpl | Updated as part of this pull request. |
| vendor/github.com/stretchr/testify/require/doc.go | Updated as part of this pull request. |
| vendor/github.com/stretchr/testify/internal/spew/README.md | Updated as part of this pull request. |
| vendor/github.com/stretchr/testify/internal/spew/LICENSE | Updated as part of this pull request. |
| vendor/github.com/stretchr/testify/internal/spew/bypasssafe.go | Updated as part of this pull request. |
| vendor/github.com/stretchr/testify/internal/difflib/LICENSE | Updated as part of this pull request. |
| vendor/github.com/stretchr/testify/assert/yaml/yaml_fail.go | Updated as part of this pull request. |
| vendor/github.com/stretchr/testify/assert/yaml/yaml_default.go | Updated as part of this pull request. |
| vendor/github.com/stretchr/testify/assert/yaml/yaml_custom.go | Updated as part of this pull request. |
| vendor/github.com/stretchr/testify/assert/http_assertions.go | Updated as part of this pull request. |
| vendor/github.com/stretchr/testify/assert/doc.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/zoneinfo.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/vm.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/thread.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/swaps.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/stat.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/slab.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/SECURITY.md | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/schedstat.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/README.md | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/proc_sys.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/proc_stat.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/proc_smaps.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/proc_psi.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/proc_ns.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/proc_maps.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/proc_limits.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/proc_io.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/proc_interrupts.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/proc_fdinfo.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/proc_environ.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/proc_cgroups.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/proc_cgroup.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/netstat.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/net_xfrm.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/net_unix.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/net_udp.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/net_tls_stat.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/net_tcp.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/net_softnet.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/net_sockstat.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/net_route.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/net_dev.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/net_conntrackstat.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/Makefile | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/loadavg.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/kernel_random.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/kernel_hung.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/ipvs.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/internal/parsers/valueparser.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/internal/parsers/sysreadfile.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/internal/parsers/sysreadfile_compat.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/internal/parsers/readfile.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/internal/parsers/parse.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/internal/fs/fs.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/fs.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/fs_statfs_type.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/fs_statfs_notype.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/doc.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/crypto.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/cpuinfo.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/cpuinfo_x86.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/cpuinfo_s390x.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/cpuinfo_riscvx.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/cpuinfo_ppcx.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/cpuinfo_others.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/cpuinfo_mipsx.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/cpuinfo_loong64.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/cpuinfo_armx.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/CONTRIBUTING.md | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/cmdline.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/buddyinfo.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/arp.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/procfs/.golangci.yml | Updated as part of this pull request. |
| vendor/github.com/prometheus/common/model/value_type.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/common/model/value_float.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/common/model/signature.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/common/model/labelset.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/common/model/alert.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/common/expfmt/fuzz.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/client_golang/prometheus/value.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/client_golang/prometheus/timer.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/client_golang/prometheus/promhttp/internal/compression.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/client_golang/prometheus/promhttp/instrument_client.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/client_golang/prometheus/process_collector.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/client_golang/prometheus/process_collector_windows.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/client_golang/prometheus/process_collector_procfsenabled.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/client_golang/prometheus/process_collector_not_supported.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/client_golang/prometheus/process_collector_mem_nocgo_darwin.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/client_golang/prometheus/process_collector_mem_cgo_darwin.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/client_golang/prometheus/num_threads.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/client_golang/prometheus/num_threads_gopherjs.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/client_golang/prometheus/labels.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/client_golang/prometheus/internal/go_runtime_metrics.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/client_golang/prometheus/go_collector.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/client_golang/prometheus/get_pid.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/client_golang/prometheus/get_pid_gopherjs.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/client_golang/prometheus/gauge.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/client_golang/prometheus/expvar_collector.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/client_golang/prometheus/counter.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/client_golang/prometheus/collectors/go_collector_latest.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/client_golang/prometheus/collectors/go_collector_go116.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/client_golang/prometheus/collectorfunc.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/client_golang/prometheus/build_info_collector.go | Updated as part of this pull request. |
| vendor/github.com/prometheus/client_golang/internal/github.com/golang/gddo/httputil/header/header.go | Updated as part of this pull request. |
| vendor/github.com/klauspost/compress/zstd/simple_go124.go | Updated as part of this pull request. |
| vendor/github.com/klauspost/compress/zstd/matchlen_generic.go | Updated as part of this pull request. |
| vendor/github.com/klauspost/compress/zstd/matchlen_amd64.s | Updated as part of this pull request. |
| vendor/github.com/klauspost/compress/zstd/matchlen_amd64.go | Updated as part of this pull request. |
| vendor/github.com/klauspost/compress/zstd/internal/xxhash/xxhash_safe.go | Updated as part of this pull request. |
| vendor/github.com/klauspost/compress/zstd/internal/xxhash/xxhash_asm.go | Updated as part of this pull request. |
| vendor/github.com/klauspost/compress/zstd/internal/xxhash/LICENSE.txt | Updated as part of this pull request. |
| vendor/github.com/klauspost/compress/zstd/hash.go | Updated as part of this pull request. |
| vendor/github.com/klauspost/compress/zstd/fse_decoder_generic.go | Updated as part of this pull request. |
| vendor/github.com/klauspost/compress/zstd/fse_decoder_amd64.go | Updated as part of this pull request. |
| vendor/github.com/klauspost/compress/SECURITY.md | Updated as part of this pull request. |
| vendor/github.com/klauspost/compress/s2sx.sum | Updated as part of this pull request. |
| vendor/github.com/klauspost/compress/s2sx.mod | Updated as part of this pull request. |
| vendor/github.com/klauspost/compress/internal/snapref/LICENSE | Updated as part of this pull request. |
| vendor/github.com/klauspost/compress/internal/le/unsafe_enabled.go | Updated as part of this pull request. |
| vendor/github.com/klauspost/compress/internal/le/unsafe_disabled.go | Updated as part of this pull request. |
| vendor/github.com/klauspost/compress/internal/le/le.go | Updated as part of this pull request. |
| vendor/github.com/klauspost/compress/internal/cpuinfo/cpuinfo.go | Updated as part of this pull request. |
| vendor/github.com/klauspost/compress/internal/cpuinfo/cpuinfo_amd64.s | Updated as part of this pull request. |
| vendor/github.com/klauspost/compress/internal/cpuinfo/cpuinfo_amd64.go | Updated as part of this pull request. |
| vendor/github.com/klauspost/compress/huff0/.gitignore | Updated as part of this pull request. |
| vendor/github.com/klauspost/compress/gen.sh | Updated as part of this pull request. |
| vendor/github.com/klauspost/compress/fse/bytereader.go | Updated as part of this pull request. |
| vendor/github.com/klauspost/compress/.gitignore | Updated as part of this pull request. |
| vendor/github.com/klauspost/compress/.gitattributes | Updated as part of this pull request. |
Review effort: Balanced
dependabot
Bot
force-pushed
the
dependabot/go_modules/github.com/prometheus/client_golang-1.25.0
branch
from
November 6, 2026 02:48
af817d9 to
9e032db
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Collaborator
|
@dependabot rebase |
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.20.5 to 1.25.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/v1.25.0/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.20.5...v1.25.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-version: 1.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/go_modules/github.com/prometheus/client_golang-1.25.0
branch
from
November 6, 2026 02:49
9e032db to
a70ab0a
Compare
|
cheyang
pushed a commit
to cheyang/fluid
that referenced
this pull request
Nov 6, 2026
…onto Go 1.26 migration fluid-cloudnative#6227 Head a70ab0a on new base 91a58c1. Harness-only change; production code untouched. - re-verify: F1 contract FIXED (all pins now 1.26.10; 21/21 CI green) - F2 covered by same contract test (11 Dockerfiles golang:1.26.10) - F3 FIXED; new guard TestGoModToolchainDirectivePresent (bites on prev head) - F4 re-confirmed under pinned go1.26.10: build/vet/tidy/vendor all clean - unit suite: no regression (env-failures identical at base/head; CI green) - nit recorded: promhttp zstd became opt-in upstream (in range since v1.24.x) - advance .last-reviewed to a70ab0a
cheyang
reviewed
Nov 6, 2026
cheyang
left a comment
cheyang
left a comment
Collaborator
There was a problem hiding this comment.
Round 2 (after the rebase onto #6227): round 1's ask was executed exactly — the Go 1.26 migration (Go 1.25.12 → 1.26.10 + x/net v0.62.0) landed first and this bump was rebased onto it, so the PR's delta vs its new base is once again just go.mod/go.sum/vendor, and it no longer touches the go/toolchain directives at all. The blocker is resolved and re-verified, not assumed: every pinned toolchain is now 1.26.10 (3 workflows, cimg/go:1.26, the 11 digest-pinned golang:1.26.10-bookworm builder images), the tree builds under the exact CI-pinned GOTOOLCHAIN=go1.26.10 on both reviewer harnesses, and all 21 checks on the head are green — including ci/circleci: build, the job whose in-container Docker builds failed in round 1; only tide is pending, waiting on approved/lgtm labels. The round-1 soundness caveat (verified only under a go1.27-class toolchain) is closed: build, vet, go mod verify and tidy/vendor stability all pass under the exact pinned 1.26.10, and the unit suite shows no PR-attributed regression (the 4 sandbox-failing packages fail identically at the new base; CI's unittest is green). The rebase also restores the toolchain directive and the CircleCI comment narrating it, and makes round 1's dependabot ignore-rule suggestion moot. One new nit, recorded so the behavior change is a deliberate acceptance rather than a silent one: promhttp's zstd response compression became opt-in inside the bump range (already true in v1.24.x, so the v1.24.1-cap alternative would have been equivalent here) — /metrics now negotiates gzip/identity, and since identity is always offered no scraper can break; a blank import of prometheus/promhttp/zstd restores zstd if it's ever wanted. Reviewer C (Copilot) reviewed this head and raised no findings. There was no disagreement between the reviewers this round — round 1's single mechanism dispute was adjudicated then and is subsumed by this fix; remaining items are pre-existing or optional only.
Next round
[MUST] none — no open findings on this PR.
[SHOULD] Maintainer approved/lgtm labels are the only thing between this head and tide merging it. Optional: blank-import prometheus/promhttp/zstd if zstd-negotiated /metrics scraping is desired; file a tracking issue for pkg/metrics' zero test coverage (pre-existing — a registration smoke test is the right guard for exactly this class of bump).
[Filed] none — M1 is the tracking-issue candidate.
Non-blocking observations (2) — not part of this round's ask; fix now, follow up, or file an issue as you see fit
- vendor/github.com/prometheus/client_golang/prometheus/promhttp/http.go:72 [nit] — promhttp zstd response compression became opt-in inside the bump range (already true in v1.24.x); fluid does not opt in — /metrics negotiates gzip/identity, no scraper can break; no action required
N2 (new this round, informational nit; proposed by Codex, every leg independently confirmed by Claude's cross-critique — consensus at nit severity, non-blocking): base vendored client_golang v1.20.5 wires zstd by default (promhttp/http.go imports klauspost/compress/zstd and declares defaultCompressionFormats = {Identity, Gzip, Zstd} unconditionally). In the bump range zstd became opt-in: defaultCompressionFormats() includes Zstd only when internal.NewZstdWriter is registered by the side-effect package prometheus/promhttp/zstd, which fluid does not import (promhttp/zstd and klauspost/compress both absent from head vendor/modules.txt; no non-vendor fluid import of promhttp/zstd). Module-cache check shows v1.24.1 already has the identical opt-in shape — the change arrived in v1.24.x, so the round-1-rejected cap-at-v1.24.1 alternative was equivalent on this axis (correct version attribution, not pinned on v1.25.0). Impact: fluid's /metrics (served via controller-runtime -> promhttp) answers zstd-preferring scrapers with gzip/identity instead of zstd; the vendored gddo NegotiateContentEncoding always offers Identity (bestOffer initialized to 'identity'), so no scraper can break — worst case is wire size/CPU, never a failed scrape. Recorded so the behavior change is a deliberate acceptance, not a silent one; if zstd is wanted back, one blank import _ "github.com/prometheus/client_golang/prometheus/promhttp/zstd" where the metrics server is wired. - pkg/metrics/dataset_metrics.go:73 [minor] — pre-existing, not introduced by this PR — pkg/metrics — the only client_golang consumer — still has zero test coverage (pre-existing; tracking-issue candidate)
M1 (unchanged from round 1, re-confirmed at head a70ab0a by both reviewers): pkg/metrics contains exactly dataset_metrics.go, labels_key_func.go, runtime_metrics.go — zero _test.go files ('go test ./pkg/metrics/...' prints '[no test files]'). A metrics-library bump is exactly when a registration smoke test (names valid under the new UTF-8-only validation, label sets, registry round-trip via testutil) would catch behavior changes — e.g. the v1.24.0 name-validation change would have been exercised by one. Pre-existing gap, not introduced by this PR: a tracking issue is enough, not a merge blocker. Candidate for [Filed]; never a gate.
Verified review delta
- F1: fixed (initial-pr)
- F2: fixed (initial-pr)
- F4: refuted (initial-pr)
- N2: open (initial-pr)
- E1: refuted (preexisting)
- Q1: fixed (initial-pr)
- M1: open (preexisting)
- F3: fixed (initial-pr)
- N1: fixed (initial-pr)
Code: clear. CI: success; attribution: baseline. Required CI checks still apply.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps github.com/prometheus/client_golang from 1.20.5 to 1.25.0.
Release notes
Sourced from github.com/prometheus/client_golang's releases.
... (truncated)
Changelog
Sourced from github.com/prometheus/client_golang's changelog.
... (truncated)
Commits
0d88875Cut v1.25.0 (#2164)e9946eeCut v1.25.0-rc.0 (#2154)de866d6Merge pull request #2152 from prometheus/dependabot/go_modules/api/prometheus...a37302fprometheus: fix modernize lint findings (#2151)a3fa380build(deps): bump google.golang.org/grpc9da3fccfix: updates for tsdb blocks handling (#1928)0ecb5c2api: match complete URL placeholders (#2136)2ad001aexp/api/remote: reset buffer before generic marshal (#2139)0db8d43promhttp: vary negotiated metrics responses (#2142)b1f9c7aMerge pull request #2144 from prometheus/dependabot/go_modules/exp/github.com...