Skip to content

Add comments to needReseThis PR is to add comments to needResetReservedPorts in fluid/pkg/ddc/base/portallocator/bitmap_allocator.go.tReservedPorts in fluid/pkg/ddc/base/portallo… #6096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
withanorchid22 wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

Add comments to needReseThis PR is to add comments to needResetReservedPorts in fluid/pkg/ddc/base/portallocator/bitmap_allocator.go.tReservedPorts in fluid/pkg/ddc/base/portallo… #6096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/ddc/base/portallocator/bitmap_allocator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ type BitMapAllocator struct {
alloc *portallocator.PortAllocator
log logr.Logger
}

// needResetReservedPorts reports whether the bitmap allocator needs to reset

@cheyang cheyang Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit: the blank line between the BitMapAllocator struct's closing } and the new godoc block was removed, so the comment now runs straight into the type declaration. Could you keep a blank line here so the doc comment stays visually attached to needResetReservedPorts rather than to the struct? The wording of the comment itself is fine.

// its reserved port state before allocating ports.
func (b *BitMapAllocator) needResetReservedPorts() bool {
return true
}
Expand Down
Loading