Skip to content

This PR is to add comments to getMasterName in fluid/pkg/ddc/alluxio/utils.go #6088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
G-Nemo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

This PR is to add comments to getMasterName in fluid/pkg/ddc/alluxio/utils.go #6088

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/ddc/alluxio/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,9 @@ func (e *AlluxioEngine) getMasterPodInfo() (podName string, containerName string

return
}

// getMasterName returns the name of the Alluxio master StatefulSet.

@gemini-code-assist gemini-code-assist Bot Jun 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To adhere to standard Go formatting and improve readability, there should be a blank line between the previous function's closing brace and this new comment block.

Suggested change
// getMasterName returns the name of the Alluxio master StatefulSet.
// getMasterName returns the name of the Alluxio master StatefulSet.

@cheyang cheyang Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous blank line between getMasterPodInfo's closing brace and this new doc comment was removed. Idiomatic Go (and what gofmt/goimports will re-introduce anyway) expects a blank line separating consecutive top-level declarations. Please keep the blank line before the // getMasterName comment.

// It constructs the name by appending "-master" to the engine's base name.
// This name is used to identify the master StatefulSet resource in Kubernetes.
func (e *AlluxioEngine) getMasterName() (dsName string) {
return e.name + "-master"
}
Expand Down
Loading