small improvements #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for this useful wrapper library. I have updated the build instructions in the readme slightly, to make it easier to understand, and fixed the URL to Oniguruma.
I have also tweaked the console test program to accept (optional) arguments to tell it what regex and what text to match and which position to start from. If there are no arguments, it uses the original text and pattern, so it can be used exactly like it was before. I also changed it to output the capture group matches. I believe these changes help to make the application useful for making small manual tests of Onigmo without detracting from the original purpose of verifying that the Onigmo dll can be loaded.
In an attempt to make the API slightly easier to understand for newcomers, I also added some doc comments that were missing.