github: introduce RuboCop minimum rules (Security & Performance check) #5012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenhys
force-pushed
the
rubocop-minimum
branch
2 times, most recently
from
6c8c00d to
28f5a04
Compare
Merged
|
Thanks! |
|
This adds a check on security and performance, right? |
kenhys
changed the title
Done! |
daipom
added a commit
that referenced
this pull request
Jun 27, 2025
**Which issue(s) this PR fixes**: * For #5012 **What this PR does / why we need it**: Refactor code for #5012 **Docs Changes**: Not needed. **Release Note**: Not needed because this is new code for v1.19. Signed-off-by: Daijiro Fukuda <[email protected]>
|
The regression has been fixed! |
Guard code regression such as follows: Offenses: test/plugin/test_buf_file.rb:26:29: C: [Correctable] Performance/StringIdentifierArgument: Use :@Write instead of "@Write". instance_variable_set("@Write", block) ^^^^^^^^ test/plugin/test_buf_file_single.rb:43:29: C: [Correctable] Performance/StringIdentifierArgument: Use :@Write instead of "@Write". instance_variable_set("@Write", block) ^^^^^^^^ Signed-off-by: Kentaro Hayashi <[email protected]>
Watson1978
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
Enable Security & Performance check with RuboCop.
Guard code regression such as follows:
Above trivial regression was introduced via #4986
Docs Changes:
N/A
Release Note:
N/A