parameterized the tagging of tail plugin#1237
parameterized the tagging of tail plugin#1237harshvora10101 wants to merge 2 commits intofluent:masterfrom
Conversation
|
@harshvora10101 Thanks for the PR. You'll need to sign your commit by: git commit -s --amend
git push -f |
| spec: | ||
| tail: | ||
| tag: kube.* | ||
| tag: {{ .Values.fluentbit.input.tail.tag }} |
There was a problem hiding this comment.
It's not enough to modify tag for tail input only.
For example, it's used by other plugins like filter and output:
https://github.com/fluent/fluent-operator/blob/master/charts/fluent-operator/templates/fluentbit-clusterfilter-kubernetes.yaml#L12
There was a problem hiding this comment.
got it.
I will update this PR with the wider plugin lists.
There was a problem hiding this comment.
and I will also sign the commits.
Signed-off-by: Harsh Vora <harsh.vora@Harshs-MacBook-Pro.local>
4b67ff3 to
34a7019
Compare
Signed-off-by: Harsh Vora <harsh.vora@Harshs-MacBook-Pro.local>
09168bb to
6231919
Compare
|
@benjaminhuo Added the required changes. |
|
There are output plugins affected too https://github.com/fluent/fluent-operator/blob/master/charts/fluent-operator/templates/fluentbit-output-opensearch.yaml#L12 Fluent Operator is used to deploy FluentBit to collect k8s logs, so kube.* is ok. cc @wanjunlei |
|
With this change, we are not changing the tag (Just making the code generalized). So I doubt that output plugins will be affected. There are use cases where we need multiple tail plugins for different applications with different tags. So a hardcoded tag is hard to change. |
|
To be precise |
|
https://github.com/fluent/fluent-operator/blob/master/charts/fluent-operator/templates/fluentbit-output-elasticsearch.yaml#L12 Shouldn't this situation be dealt with as well? |
|
@harshvora10101 can you resolve the merge conflicts |
|
Closing due to inactivity. Please re-open if necessary. |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes 1 :
Parameterising the tag for tail plugin. Overriding this value will help changing the tags according to the requirements.