bug-fix : Check for clang build dependency when building ebpf #9926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhi-jha
requested review from
celalettin1286,
fujimotos,
niedbalski and
patrick-stephens
as code owners
abhi-jha
force-pushed
the
abhishek/fix-ebpf-build-with-clang
branch
2 times, most recently
from
aa1fc7c to
3310f3c
Compare
|
I believe that just checking existence of clang is not enough. Should we add a constraint of version for clang? |
|
We can add a version check for clang for minimum version requirement. |
Signed-off-by: Abhishek Jha <[email protected]>
abhi-jha
force-pushed
the
abhishek/fix-ebpf-build-with-clang
branch
from
dadbf8e to
382292f
Compare
|
@cosmo0920 Let me know if there's more to be done here. |
niedbalski
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for clang compiler during building ebpf.
Currently the doc doesn't mention clang dependency explicitly : https://docs.fluentbit.io/manual/pipeline/inputs/ebpf
Doc fix : fluent/fluent-bit-docs#1570