workflows: allow the use of an underscore ('_') in commit message #3270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We needed this in order to allow a commit message like this:
out_splunk: prioritize http basic auth over splunk token
In general, we refer to each plugin by "(in|out)_[a-z]*", so an
underscore should be included in the allowed list.
Signed-off-by: Fujimoto Seiji <[email protected]>
|
This PR's commit reproduces issue. Nice. |
Yes, it was kinda neat. I see a few PRs failing due to this issue. They should be all fine ADDENDUM: It seems that the "commit message" checker actually |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed this in order to allow a commit message like this:
In general, we refer to each plugin by "(in|out)_[a-z]*", so an
underscore should be included in the allowed list.
Signed-off-by: Fujimoto Seiji [email protected]