Skip to content

Update BitBake file to modern overwrite syntax#11471

Open
JoVanRanst wants to merge 1 commit intofluent:masterfrom
JoVanRanst:patch-2
Open

Update BitBake file to modern overwrite syntax#11471
JoVanRanst wants to merge 1 commit intofluent:masterfrom
JoVanRanst:patch-2

Conversation

@JoVanRanst
Copy link

@JoVanRanst JoVanRanst commented Feb 16, 2026

Since Yocto honister (v3.4) the overwrite syntax has changed from using underscores to colons.

Changed the TARGET_CC_ARCH_append to the modern TARGET_CC_ARCH:append syntax.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • [ x] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Summary by CodeRabbit

  • Chores
    • Updated build configuration syntax to align with current BitBake standards for improved compatibility and long-term maintainability.

Since Yocto honister (v3.4) the overwrite syntax has changed from using underscores to collons.

Changed the TARGET_CC_ARCH_append to the modern TARGET_CC_ARCH:append syntax.

Signed-off-by: Jo Van Ranst <jovranst@gmail.com>
@coderabbitai
Copy link

coderabbitai bot commented Feb 16, 2026

📝 Walkthrough

Walkthrough

A BitBake recipe file is updated to use modern variable append syntax. The TARGET_CC_ARCH_append assignment is converted to TARGET_CC_ARCH:append, replacing the legacy underscore-based syntax with the current colon-based format in one line.

Changes

Cohort / File(s) Summary
BitBake Recipe Syntax Update
fluent-bit-5.0.0.bb
Updated variable append syntax from legacy underscore format (_append) to modern colon format (:append).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A colon, a dash, a syntax so neat,
Where variables append with modern technique!
From underscore ways to colon's delight,
This fluent-bit recipe now shines so bright! ✨

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating BitBake syntax from older underscore append form to modern colon form (TARGET_CC_ARCH_append → TARGET_CC_ARCH:append).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into master

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
fluent-bit-5.0.0.bb (1)

26-26: ⚠️ Potential issue | 🟠 Major

Same legacy underscore override syntax needs updating here.

INSANE_SKIP_${PN}-dev uses the old underscore-based override form. For consistency with the line 57 fix and compatibility with Yocto Honister+, this should also be converted to the colon form.

Proposed fix
-INSANE_SKIP_${PN}-dev += "dev-elf"
+INSANE_SKIP:${PN}-dev += "dev-elf"
🤖 Fix all issues with AI agents
In `@fluent-bit-5.0.0.bb`:
- Line 56: Replace the legacy override-style variable SYSTEMD_SERVICE_${PN} with
the Honister+ colon override syntax by changing the override to use :pn (i.e.
SYSTEMD_SERVICE:pn) so the variable becomes SYSTEMD_SERVICE:pn =
"fluent-bit.service"; update the line that sets SYSTEMD_SERVICE_${PN} to use
SYSTEMD_SERVICE:pn to conform with Yocto Honister+ override syntax.

@@ -54,4 +54,4 @@ EXTRA_OECMAKE += "-DFLB_IN_SYSTEMD=On "
inherit cmake systemd

SYSTEMD_SERVICE_${PN} = "fluent-bit.service"
Copy link

@coderabbitai coderabbitai bot Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Same legacy underscore override syntax needs updating here.

SYSTEMD_SERVICE_${PN} is also an override-style variable that requires the colon form in Yocto Honister+.

Proposed fix
-SYSTEMD_SERVICE_${PN} = "fluent-bit.service"
+SYSTEMD_SERVICE:${PN} = "fluent-bit.service"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
SYSTEMD_SERVICE_${PN} = "fluent-bit.service"
SYSTEMD_SERVICE:${PN} = "fluent-bit.service"
🤖 Prompt for AI Agents
In `@fluent-bit-5.0.0.bb` at line 56, Replace the legacy override-style variable
SYSTEMD_SERVICE_${PN} with the Honister+ colon override syntax by changing the
override to use :pn (i.e. SYSTEMD_SERVICE:pn) so the variable becomes
SYSTEMD_SERVICE:pn = "fluent-bit.service"; update the line that sets
SYSTEMD_SERVICE_${PN} to use SYSTEMD_SERVICE:pn to conform with Yocto Honister+
override syntax.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoVanRanst Could you take a look on it?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

@@ -54,4 +54,4 @@ EXTRA_OECMAKE += "-DFLB_IN_SYSTEMD=On "
inherit cmake systemd

SYSTEMD_SERVICE_${PN} = "fluent-bit.service"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoVanRanst Could you take a look on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants