Update BitBake file to modern overwrite syntax#11471
Update BitBake file to modern overwrite syntax#11471JoVanRanst wants to merge 1 commit intofluent:masterfrom
Conversation
Since Yocto honister (v3.4) the overwrite syntax has changed from using underscores to collons. Changed the TARGET_CC_ARCH_append to the modern TARGET_CC_ARCH:append syntax. Signed-off-by: Jo Van Ranst <jovranst@gmail.com>
📝 WalkthroughWalkthroughA BitBake recipe file is updated to use modern variable append syntax. The Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
fluent-bit-5.0.0.bb (1)
26-26:⚠️ Potential issue | 🟠 MajorSame legacy underscore override syntax needs updating here.
INSANE_SKIP_${PN}-devuses the old underscore-based override form. For consistency with the line 57 fix and compatibility with Yocto Honister+, this should also be converted to the colon form.Proposed fix
-INSANE_SKIP_${PN}-dev += "dev-elf" +INSANE_SKIP:${PN}-dev += "dev-elf"
🤖 Fix all issues with AI agents
In `@fluent-bit-5.0.0.bb`:
- Line 56: Replace the legacy override-style variable SYSTEMD_SERVICE_${PN} with
the Honister+ colon override syntax by changing the override to use :pn (i.e.
SYSTEMD_SERVICE:pn) so the variable becomes SYSTEMD_SERVICE:pn =
"fluent-bit.service"; update the line that sets SYSTEMD_SERVICE_${PN} to use
SYSTEMD_SERVICE:pn to conform with Yocto Honister+ override syntax.
| @@ -54,4 +54,4 @@ EXTRA_OECMAKE += "-DFLB_IN_SYSTEMD=On " | |||
| inherit cmake systemd | |||
|
|
|||
| SYSTEMD_SERVICE_${PN} = "fluent-bit.service" | |||
There was a problem hiding this comment.
Same legacy underscore override syntax needs updating here.
SYSTEMD_SERVICE_${PN} is also an override-style variable that requires the colon form in Yocto Honister+.
Proposed fix
-SYSTEMD_SERVICE_${PN} = "fluent-bit.service"
+SYSTEMD_SERVICE:${PN} = "fluent-bit.service"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| SYSTEMD_SERVICE_${PN} = "fluent-bit.service" | |
| SYSTEMD_SERVICE:${PN} = "fluent-bit.service" |
🤖 Prompt for AI Agents
In `@fluent-bit-5.0.0.bb` at line 56, Replace the legacy override-style variable
SYSTEMD_SERVICE_${PN} with the Honister+ colon override syntax by changing the
override to use :pn (i.e. SYSTEMD_SERVICE:pn) so the variable becomes
SYSTEMD_SERVICE:pn = "fluent-bit.service"; update the line that sets
SYSTEMD_SERVICE_${PN} to use SYSTEMD_SERVICE:pn to conform with Yocto Honister+
override syntax.
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
| @@ -54,4 +54,4 @@ EXTRA_OECMAKE += "-DFLB_IN_SYSTEMD=On " | |||
| inherit cmake systemd | |||
|
|
|||
| SYSTEMD_SERVICE_${PN} = "fluent-bit.service" | |||
Since Yocto honister (v3.4) the overwrite syntax has changed from using underscores to colons.
Changed the TARGET_CC_ARCH_append to the modern TARGET_CC_ARCH:append syntax.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit