lib: wasm: avoid executable stack as a result of wasm assembler. #10514
Conversation
jkroonza
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
patrick-stephens
added
dependencies
|
@jkroonza can you update the commits and PR title to follow the contribution guidelines? Plus follow the PR template as much as you can as it has important things in it to help reviewers and future devs who look at the PR. |
Add a GUN-stack note to the assembly to state that an executable stack is not required (by default a stack is executable unless stated otherwise, this makes that statement). Closes: fluent#10513 Signed-off-by: Jaco Kroon <[email protected]>
Should be more in line now? I also note that special action may be required to get this into the next minor release? Is that correct? If so, what do I need to do? |
|
Ah, this is an update to the dependency - we do not do that directly as it is a nightmare to manage future updates from upstream. Instead the approach is to merge the PR upstream and get a release there we can then update Fluent Bit with. |
patrick-stephens
changed the title
|
Welcome to close then :). I've already included the patch locally into gentoo, so no harm no foul, but it is indeed quite annoying that these issues still crop up in 2025. |
Closes: #10513