Skip to content

es_out: support Upstream Servers with configuration overriding #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

es_out: support Upstream Servers with configuration overriding #1143

wants to merge 4 commits into from

Conversation

mabrarov
Copy link

Implementation of Upstream feature for the Elasticsearch output plugin.

Refer to fluent/fluent-bit#7608 for the changes in Fluent Bit code.

@mabrarov mabrarov mentioned this pull request Jun 25, 2023
Open
4 tasks
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from cb36f75 to 7611f0e Compare June 25, 2023 09:01
@mabrarov mabrarov mentioned this pull request Jun 25, 2023
Open
@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Sep 24, 2023
@mabrarov
Copy link
Author

This pull request is waiting for review of fluent/fluent-bit#7608

@github-actions github-actions bot removed the Stale label Sep 25, 2023
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Dec 24, 2023
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from 7611f0e to 25c7642 Compare December 24, 2023 09:14
@github-actions github-actions bot removed the Stale label Dec 25, 2023
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from 25c7642 to 7138a28 Compare February 24, 2024 11:09
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from 7138a28 to c1092dc Compare August 29, 2024 07:21
@mabrarov mabrarov requested review from a team as code owners August 29, 2024 07:21
cnorris-cs
cnorris-cs reviewed Aug 29, 2024
View reviewed changes
cnorris-cs
cnorris-cs reviewed Aug 29, 2024
View reviewed changes
cnorris-cs
cnorris-cs reviewed Aug 29, 2024
View reviewed changes
cnorris-cs
cnorris-cs reviewed Aug 29, 2024
View reviewed changes
cnorris-cs
cnorris-cs reviewed Aug 29, 2024
View reviewed changes
cnorris-cs
cnorris-cs reviewed Aug 29, 2024
View reviewed changes
cnorris-cs
cnorris-cs reviewed Aug 29, 2024
View reviewed changes
cnorris-cs
cnorris-cs approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@cnorris-cs cnorris-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left suggestions, but I've added my technical writing-based approval based on that to keep this moving.

Primarily, I was looking to help the table be more consistent and readable, while implementing some style-based suggestions for consistency.

@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch 2 times, most recently from a78ebf2 to c620db5 Compare August 29, 2024 13:51
@mabrarov
Copy link
Author

Hi @cnorris-cs,

I applied some (!) parts of your suggestions as well as introduced additional changes for consistency with your suggestions. Please take a look at this pull request one more time when you have time. Some of the changes are implemented in dedicated commits (for ease of revert in case of concerns) - please let me know if I need to squash all commits into a single one.

Thank you for your review.

@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from c620db5 to 23f04ef Compare October 13, 2024 15:28
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from 23f04ef to d8bad1b Compare October 25, 2024 04:02
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from d8bad1b to d465436 Compare November 10, 2024 19:25
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from 6546d15 to 2d9ae77 Compare December 18, 2024 15:50
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from 2d9ae77 to 8448868 Compare March 9, 2025 15:11
patrick-stephens
patrick-stephens reviewed Mar 10, 2025
View reviewed changes
patrick-stephens
patrick-stephens reviewed Mar 10, 2025
View reviewed changes
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from d318151 to 4b84694 Compare April 30, 2025 19:47
@mabrarov mabrarov requested a review from patrick-stephens May 2, 2025 15:17
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from 4b84694 to 469c0ea Compare May 16, 2025 00:54
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch 2 times, most recently from 2dd2d3b to feefc9f Compare May 30, 2025 00:57
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from feefc9f to 6051778 Compare May 31, 2025 17:30
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from 6051778 to 148fce1 Compare June 11, 2025 22:48
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch 4 times, most recently from fac2cc7 to 8ed632e Compare June 22, 2025 04:42
@esmerel
Copy link
Contributor

esmerel commented Jun 23, 2025

This still looks ok to me from a writing perspective.

@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from 8ed632e to af68253 Compare July 6, 2025 12:51
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch 3 times, most recently from c02d041 to 312b9a1 Compare July 21, 2025 20:50
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from 312b9a1 to 02dbd5d Compare July 27, 2025 14:38
esmerel
esmerel reviewed Jul 28, 2025
View reviewed changes
Copy link
Contributor

@esmerel esmerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor stylistic suggestions for consistency, but these docs changes look good to me otherwise.

@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from 02dbd5d to da614db Compare August 2, 2025 19:48
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch 2 times, most recently from dee1a67 to 6379bf2 Compare August 22, 2025 23:30
@mabrarov mabrarov force-pushed the feature/out_es_upstream_support_extended branch from 6379bf2 to dd6d5da Compare August 28, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esmerel esmerel esmerel left review comments

@cnorris-cs cnorris-cs cnorris-cs approved these changes

@patrick-stephens patrick-stephens Awaiting requested review from patrick-stephens

Assignees
No one assigned
Labels
waiting-on-code-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mabrarov @lockewritesdocs @esmerel @patrick-stephens @cnorris-cs @lecaros