Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable kubelet test #133

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Conversation

ryanohnemus
Copy link
Contributor

Commenting out the kubelet test as it always fails CI

Signed-off-by: ryanohnemus <[email protected]>
@ryanohnemus
Copy link
Contributor Author

ryanohnemus commented Jan 24, 2024

@patrick-stephens im stuck in my debugging at this point. While running on a local kind cluster everything with the kubelet enabled test works perfectly fine. Once it's deployed in the CI the kubelet enabled test always fails.

It's one of these possible issues:

  1. the rbac.nodeAccess: true isn't creating the clusterrole the with the needed nodes/proxy role (this seems impossible looking through the fluent-bit helm) and I confirmed in local kind it creates the correct role and rolebinding (even when using fullnameOverride). I mentioned this one first because by setting nodeAccess to false (the default) you will get the exact same results locally as the CI

  2. kubelet settings are different / we can not access kubelet via the hostIP in the same way we can in a local kind cluster. Things we could try is using a daemonset with host networking enabled, allowing us to just connect to kubelet via 127.0.0.1:10250 instead of using the hostIP

Do you have any suggestions on what we can do? Otherwise for now, I've commented out the kubelet test since I've never been able to get it to work via CI 😔

@patrick-stephens
Copy link
Collaborator

It's probably something with GKE defaults blocking it. Can you raise an issue then add a skip statement to the test referencing the issue? I'd prefer that as a better way to document that this test is disabled for a valid reason.

I know people have troubles in the Slack with kubelet enabled too

@ryanohnemus
Copy link
Contributor Author

@patrick-stephens thank you for the suggestion, I've opened #134 for this and added the skip as suggested. Thanks again for the help!

@patrick-stephens patrick-stephens merged commit 50da448 into fluent:main Jan 25, 2024
7 of 8 checks passed
@ryanohnemus ryanohnemus deleted the debug_kubelet_test branch January 28, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants