Add return type to home indicator component #47
Conversation
By only typing the props, the HomeIndicator component was missing a clear return type. This change instead types the functional component, setting the return type to be a React Functional Component that will accept the properties defined in Props.
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 25 25
Branches 4 4
=========================================
Hits 25 25
Continue to review full report at Codecov.
|
| @@ -6,7 +6,7 @@ const isIos = Platform.OS === "ios"; | |||
|
|
|||
| type Props = { autoHidden: boolean }; | |||
|
|
|||
| export const HomeIndicator = (props: Props) => { | |||
| export const HomeIndicator: React.FC<Props> = (props) => { | |||
There was a problem hiding this comment.
the problem with React.FC is that it implicitly adds children to the props.
export const HomeIndicator = (props: Props): ReactElement | null => { could work, but this is a bit unusual
There was a problem hiding this comment.
That is a good point and a reason to move away from using React.FC in general. Your alternative seems reasonable to me, and for TypeScript support helps us more than any, why would it be unusual in your opinion?
Thank you for making this library and for adding TypeScript to it! When updating to v0.2.9 I found that although the properties are now properly typed, my TS configuration still gave me a warning:
By only typing the props, the HomeIndicator component was missing a clear return type. This proposed change instead types the functional component, setting the return type to be a React Functional Component that will accept the properties defined in Props.
Cheers!