FDN-4209 Update pr-validator workflow

[jlogeart]

Resolves FDN-4209

Summary by CodeRabbit

Release Notes

• Chores
  • Strengthened PR title validation requirements: titles must now start with 3+ uppercase letters, followed by a dash and 3-6 digits (non-zero).
  • Removed PR description validation; title format is now the sole validation requirement.
  • Simplified PR validation workflow by removing label-based checks.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR validator GitHub Actions workflow is updated to enforce stricter JIRA ticket validation in PR titles using a refined regex pattern, remove PR description validation, eliminate label-based conditional gating, and simplify error handling to return a single string message instead of an array.

Changes

Cohort / File(s)	Summary
GitHub Actions Workflow Configuration .github/workflows/pr-validator.yml	Removed PR label conditional check; replaced JIRA pattern with stricter rule (3+ uppercase letters, dash, 3–6 digits, non-zero); removed description validation; consolidated validation to title-only check; changed error output from array to single string; updated logging messages.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Verify the updated JIRA regex pattern correctly matches intended ticket format (3+ uppercase letters, dash, 3–6 digits, no all-zeros)
• Confirm removal of description validation doesn't impact other PR validation requirements
• Check that the simplified error handling properly propagates to workflow failure reporting

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'FDN-4209 Update pr-validator workflow' clearly and specifically describes the main change: updating the pr-validator workflow with the JIRA ticket reference.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull Request Overview

This PR updates the PR validator workflow to enforce stricter JIRA ticket validation rules. The validator now only checks PR titles (not descriptions), requires JIRA tickets at the beginning of the title, enforces a minimum 3-character prefix, validates 3-6 digit ticket numbers, and excludes all-zero ticket numbers. The scala-steward label exclusion has also been removed.

• Updated JIRA ticket regex pattern with stricter validation rules
• Removed PR description validation, now only validates title
• Removed scala-steward label bypass condition

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

.github/workflows/pr-validator.yml (1)

1-1: Update workflow and job names to reflect title-only validation.

The workflow currently validates only the PR title (description validation was removed per PR objectives), but the names on lines 1 and 7 still reference "description." For clarity to workflow consumers, consider updating these names.

-name: "PR Title and Description Check"
+name: "PR Title Check"
...
   check-title-and-description:
+  check-pr-title:

Also applies to: 7-7

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9141ba0 and 0cb6fbe.

📒 Files selected for processing (1)

• .github/workflows/pr-validator.yml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Jenkins

🔇 Additional comments (2)

.github/workflows/pr-validator.yml (2)

18-23: Regex pattern correctly enforces strict JIRA validation requirements.

The negative lookahead (?!0+\b) effectively rejects all-zero ticket numbers while the rest of the pattern correctly enforces 3+ uppercase letters, dash separator, and 3-6 digits. The comments clearly document the intent. ✓

---

29-36: Error handling is clean and the validation message is clear.

The simplified flow (title-only validation) is appropriate per PR objectives. The error message clearly communicates all constraints and provides concrete examples. The use of core.setFailed() with a single string is the correct pattern for GitHub Actions. ✓

[mikeclimbrock]

lgtm