add ct labels support #70
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! 🙏 |
I followed up on the mail thread in the description asking about the size of the labels array |
2 tasks
|
It seems is indeed 16 bytes https://github.com/vishvananda/netlink/pull/1135/files#r2449806010 |
Signed-off-by: Antonio Ojea <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to set CT labels, that is very useful for scenarios like kubernetes, see full context in https://lore.kernel.org/netfilter-devel/[email protected]/T/#mae18a8bb815a95d7bd8a496792bd6e0ee9029e00
and kubernetes-sigs/kube-network-policies#268
This is basically a copy paste of SetVerdictWithConnMark and SetVerdictModPacketWithConnMark but passing the byte array directly.
I do not know if the kernel expects an specific format, it seems to me that only works with a 16 byte array, but I can not fully confirm that is the contract. In case that is the case we can do some input validation