Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add src folder to package.json files field #312

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vafanassieff
Copy link

Hey, it seems you are building with source maps, but you are missing the src folder in the files field from package.json.

Best

@vafanassieff vafanassieff requested a review from Skn0tt as a code owner January 17, 2025 09:29
@Skn0tt
Copy link
Collaborator

Skn0tt commented Jan 17, 2025

I'm not sure we're building with sourcemaps on purpose. How did you stumble across this? Would source maps and source files have helped you to debug something?

@vafanassieff
Copy link
Author

vafanassieff commented Jan 17, 2025

I updated vitest to 3.0.1 and vite to 6.0.7, and I got a warning when running tests on my frontend app.

Sourcemap for "node_modules/.pnpm/[email protected]/node_modules/superjson/dist/index.js" points to missing source files

Source maps are useful if you want your IDE to go to typescript files instead of the dist folder.

I got this warning and just wanted to remove it, for clarity’s sake.
If you don't ship src folder, you don't need to build with source maps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants