fix: aspect ratio and opacity types (#147)

* Fix aspect ration and opacity type * Add ability to set `aspectRatio` in the constructor
flekschas · Aug 9, 2023 · 805694b · 805694b
1 parent cc23a7c
commit 805694b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+## 1.8.1
+
+- Add ability to set `aspectRatio` in the constructor
+- Add type for `aspectRatio`
+- Fix type of `opacity`
+
 ## 1.8.0
 
 - Add `scatterplot.getScreenPosition(pointIdx)` to retrieve the screen position of a point by its index.

diff --git a/src/index.js b/src/index.js
@@ -301,7 +301,8 @@ const createScatterplot = (
   let lassoPointsCurr = [];
   let searchIndex;
   let viewAspectRatio;
-  let dataAspectRatio = DEFAULT_DATA_ASPECT_RATIO;
+  let dataAspectRatio =
+    initialProperties.aspectRatio || DEFAULT_DATA_ASPECT_RATIO;
   let projectionLocal;
   let projection;
   let model;

diff --git a/src/types.d.ts b/src/types.d.ts
@@ -94,13 +94,14 @@ interface BaseOptions {
   showPointConnections: boolean;
   showReticle: boolean;
   reticleColor: Color;
-  opacity: number;
+  opacity: number | Array<number>;
   opacityByDensityFill: number;
   opacityInactiveMax: number;
   opacityInactiveScale: number;
   height: 'auto' | number;
   width: 'auto' | number;
   gamma: number;
+  aspectRatio: number;
   // Nullifiable
   backgroundImage: null | import('regl').Texture2D | string;
   colorBy: null | DataEncoding;