Make sure the Host Registry XdpAppInfo updates become visible #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The invocations are currently delegated to threads which means that the next invocation gets run before the first one finished. This is fine for all the other portals, but because the Registry modifies the identity of the caller for all following calls, we must ensure that it finishes before the next invocation. This means in particular no g-authorize-method and no FLAGS_HANDLE_METHOD_INVOCATIONS_IN_THREAD.
|
Should probably add a test for it as well. |
grulja
approved these changes
Feb 25, 2025
jadahl
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The invocations are currently delegated to threads which means that the next invocation gets run before the first one finished. This is fine for all the other portals, but because the Registry modifies the identity of the caller for all following calls, we must ensure that it finishes before the next invocation. This means in particular no g-authorize-method and no FLAGS_HANDLE_METHOD_INVOCATIONS_IN_THREAD.