-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XdpAppInfo refactoring #1623
base: main
Are you sure you want to change the base?
XdpAppInfo refactoring #1623
Conversation
This is especially useful when the binaries are run as part of a test and getting the debugger to the right place takes a bit of effort.
Purely cosmetics.
They're not public.
* Add space before '(' * gchar → char * Remove stray newline
It's unused.
Makes it slightly easier to read.
We'll start shuffling things around, so that XdpAppInfo & subclasses operate with the mechanics proposed by GInitable.
8c4eb49
to
3511b2d
Compare
The "mess" the I mentioned in my PR is having to add private setters for private fields of the parent class. I ended up with similar diff and I still dislike it. Which is why I opted for the splitting up the properties, and handling the construction complexity in the I like the tests this PR introduces, but I don't think the XdpAppInfo changes are worth it. |
At least when using pid and pidfd as construction properties, and then using setters in the initable_init, we get uniform construction via When using |
Tried to minimize the changes to get the improved XdpAppInfo testability #1627 |
Using construct properties is a common pattern used in GObject code bases to plumb things up the type chain without having to add private setters. |
Contains a few commits from #1619.
Still a bit rough and needs some cleaning up, but I think the end result is a good improvement.