print: Add "supported_output_file_formats" option #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgesStavracas
force-pushed
the
gbsneto/printing-savage
branch
2 times, most recently
from
7f68103 to
1e472cd
Compare
TingPing
approved these changes
Apr 3, 2024
|
I assume this will need a corresponding gtk change to say that we only do pdf ? |
|
Looks fine to me too |
No. I actually thought so, and started looking at GtkPrintOperation - but realized soon enough that, actually, GtkPrintOperation is good and respect the output file format, it uses cairo-pdf for PDF, cairo-ps for PostScript, and plain cairo for SVG. |
This allows applications tell portal backends which file formats they support. In turn, portal backends can then limit the choices presented to the user.
GeorgesStavracas
force-pushed
the
gbsneto/printing-savage
branch
from
1e472cd to
9b05b7b
Compare
|
I think this is fine from Qt POV, my understanding is that it can only print to PDF. |
webkit-commit-queue
pushed a commit
to GeorgesStavracas/WebKit
that referenced
this pull request
Apr 22, 2024
https://bugs.webkit.org/show_bug.cgi?id=272913 Reviewed by Michael Catanzaro and Carlos Garcia Campos. Skia only supports printing to PDF files, but the Print portal assumes that apps can print to PDF, PS, and SVG formats. If the user selects PS or SVG through the Print portal dialog, and WebKit is using Skia, we hit an assertion failure. The next release of XDG Desktop Portal has new API [1] in the Print portal made specifically to aid this, we can use it for Skia builds and if the portal version matches. [1] flatpak/xdg-desktop-portal#1322 * Source/WebKit/UIProcess/API/gtk/WebKitPrintOperation.cpp: (webkitPrintOperationPreparePrint): Canonical link: https://commits.webkit.org/277806@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows applications tell portal backends which file formats they
support. In turn, portal backends can then limit the choices presented
to the user.