-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid showing dialog for screenshare request #523
Comments
As someone who has been recently trying very hard to improve the situation in Chromium, I share your concerns. However, you cannot compare FileChooser with ScreenCast as with FileChooser you still require a user interaction. The reason why it's done this way is mostly to improve security. On X any app was able to get any kind of information, but Wayland has been prototyped with security in mind and with that you cannot easily get screen content without letting the user to know about it. |
Yeah FileChooser need user interaction and I mentioned that just to explain things, but dialog can be avoided for screencast request. |
Have we considered showing a dialog but having a broad "allow everything"? If Chromium could request 'let me grab everything' the portal dialog would only have approve/deny in it, then Chromium could just keep its normal dialog showing all tabs, windows and desktops for the user to select. |
See also #324 which asks for a "remember this decision" checkbox, or some way to pre-seed an entry in the permissions store, so that an app does not necessarily have to prompt every time. |
Both my suggestion and what @smcv mentioned seem to be what Mac OS does FWIW. Application asks for broad access at startup, decision is remembered. Pre-seeding would be nice, but may be hard to audit I guess? |
The description of this issue makes it somewhat of a duplicated of #324, but what is being asked is being tracked #800. The plumbing for storing screensharing sessions is in, @grulja has been working on #800 for the rest. So let's continue tracking this on #800 since it's where most of the relevant discussion is happening. |
I have encountered a use case where avoiding screenshare dialog will help to run apps elegantly. So I am raising this as bug to start discussion about this and collaboratively figure out if it is possible for portal implementation to avoid showing screenshare dialog.
Here is background of its requirement
Chromium webrtc screenshare feature on linux/wayland is based on screenshare portal api call which works but dialog UI are messy. Chromium itself has its own implementation of dialog to choose either screen/window/tab and make sense since it also allow selecting tab sharing in same dialog. But while sharing, screenshare portal dialog also shows up and we have two dialog for screenshare and creates ambiguity. Hiding/Adjusting chromium dialog has been denied since it also supports tab sharing
Hiding portal dialog will solves this UI issue, So I was wondering if this is worth considering. Please comment your views on this.
Another consideration related to this is that portal api are not only used from sandbox applications to bypass sandbox but also
used by non sandbox application to target many desktop environment. e.g I can call portal api to launch FileChooser and code will work for both gtk and kde seamlessly. So Is it possible to avoid extra dialog for those non-sandbox application as those already have full access to system
The text was updated successfully, but these errors were encountered: