Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steam asks to share my screen on every startup #8098

Closed
Newbytee opened this issue Sep 23, 2021 · 20 comments
Closed

Steam asks to share my screen on every startup #8098

Newbytee opened this issue Sep 23, 2021 · 20 comments

Comments

@Newbytee
Copy link

Your system information

  • Steam client version (build number or date): Sep 23 2021, at 14:35:28
  • Distribution (e.g. Ubuntu): Fedora 34 GNOME
  • Opted into Steam client beta?: Yes
  • Have you checked for system updates?: Yes

Please describe your issue in as much detail as possible:

Right on startup of Steam, without initiating a remote play session or such, Steam causes this popup to appear:

image

Steps for reproducing this issue:

  1. Launch Steam on GNOME with PipeWire set up for screen sharing
  2. Start Steam
  3. Observe that Steam asks if you want to share your screen through PipeWire, even though you didn't initiate screen sharing
@kisak-valve
Copy link
Member

Hello @Newbytee, this looks like an intended change per Enabled pipewire desktop capture by default on Linux, pass -nopipewire on the command line to disable it in the 2021-09-23 Steam client beta update.

@Newbytee
Copy link
Author

Newbytee commented Sep 23, 2021

I would be very surprised if this is intentional. Generally, applications that use PipeWire should ask when they need it, not right on startup. Users should understand why they are sharing their screen, and there is no clear indication why my screen is being shared here.

@Bednar87
Copy link

Bednar87 commented Sep 23, 2021

I am experiencing the same issue on Arch KDE wayland session. The dialog shows up each time Steam starts. This definitely is not right.

@Daedrin
Copy link

Daedrin commented Sep 23, 2021

I can confirm this as well. Pipewire should not be asking for this information on launch, rather when it is being called. I have all remote play, broadcasting, etc disabled in the client and it's still asking for this information on launch.

@minecraft2048
Copy link

minecraft2048 commented Sep 24, 2021

WIP bug report: If I accept the share screen request, any games that uses Proton will not show their window at all. I haven't tested this with Linux native games. If I didn't accept the request, the games runs normally

EDIT: I cannot reproduce this anymore, seems like everything works normally

@minecraft2048
Copy link

I would be very surprised if this is intentional. Generally, applications that use PipeWire should ask when they need it, not right on startup. Users should understand why they are sharing their screen, and there is no clear indication why my screen is being shared here.

I can see why they are doing it though, when you are starting a game through remote play you tend to be not in front of the desktop to accept screen sharing request.

@smcv
Copy link
Contributor

smcv commented Sep 24, 2021

I can see why they are doing it though, when you are starting a game through remote play you tend to be not in front of the desktop to accept screen sharing request.

I'm pretty sure that's the reasoning for doing it this way, rather than each time Remote Play streaming is initiated. Part of the design of Remote Play is that it's initiated by the thin client (phone, laptop, Steam Link, smart-TV) rather than by the "big" gaming PC where the actual game runs, which might be in a different room.

See also flatpak/xdg-desktop-portal#324: it's not currently possible to say "yes, share the screen, and always allow this in future", or programmatically set up permission non-interactively.

See also flatpak/xdg-desktop-portal#523: it's not currently possible for Steam to say "I want to capture the whole screen, don't ask the user whether to share individual windows or the whole screen".

Perhaps the least-bad UX available, given what's currently possible, would be something like this:

  • by default, only start capturing the screen when streaming starts;
  • have an option somewhere (in Settings, and maybe also in the pairing dialog for easy access?) to start capturing the screen immediately on Steam startup, with the intention that people who use Remote Play more often would enable this option

@DanMan
Copy link

DanMan commented Sep 24, 2021

The least that should be changed is that it shouldn't even ask for permission, if I have Remote Play completely disabled in the settings. I consider that happening nonetheless a bug.

@avoonix
Copy link

avoonix commented Sep 25, 2021

Not sure if steam can choose the screen on it's own (maybe always the primary display), but that would be very helpful.
I'm not sure which monitor is which:
image

Something like this would be better:
image

@minecraft2048
Copy link

From flatpak/xdg-desktop-portal#324 it seems that @smcv don't want to duplicate the desktop specific code to access Pipewire, and in Flatpak this isn't possible at all. But it shows a UI problem in the portal chooser

@jmariondev
Copy link

@avoonix That UI is not part of Steam but rather xdg-desktop-portal-gtk, The behavior you're describing is something I've also really wanted and that ticket is at flatpak/xdg-desktop-portal-gtk#333.

@minecraft2048
Copy link

There is a problem, but maybe this is more of a KDE problem not Steam problem. Or maybe this is portal problem. If I accepted the screen share prompt, KDE notification center automatically switches to do not disturb mode:

image

If I accept the screen share prompt for remote play to work, I lose my notifications unless I manually uncheck the do not disturb mode after accepting the prompt.
Will using RemoteDesktop in combination with ScreenCast fix this?

@kisak-valve
Copy link
Member

Hello @minecraft2048, that sounds like something to ask the KDE devs about. Most likely an unrelated issue.

@Newbytee
Copy link
Author

I would guess this is a "feature" since it thinks when you share your screen you're probably presenting or such.

@kisak-valve
Copy link
Member

Hello, per "Pipewire desktop capture is disabled by default on Linux, launch Steam with the -pipewire command line option to enable" in the 2021-09-28 Steam client beta update, this issue should now be resolved. As the release note suggests, you now need to opt-in to the pipewire integration if you want to experiment with using Steam's Remote Play from a wayland-based desktop session.

@major-mayer
Copy link

I would guess this is a "feature" since it thinks when you share your screen you're probably presenting or such.

I think the whole user experience around the portal wasn't designed with use cases in mind like steam has 😐

@rohmishra
Copy link

Perhaps using flatpak/xdg-desktop-portal#638 once it is merged might be a better solution in long run.

@dc740
Copy link

dc740 commented Sep 27, 2022

Update on 2022:
Ubuntu/fedora have wayland by default.

Broken scenario:
You start remote play from the couch. is: Steam Link starts a new session and/or uses wake-on-lan to turn on the PC and start Steam.
Steam doesn't even ask to share the screen.
Steam Link sees a black screen unless you physically go to the PC, restart steam with -pipewire argument, and manually share the screen.

I don't think this bug should be closed.

@kisak-valve
Copy link
Member

Hello @dc740, you're looking for the issue being tracked at #6148 instead of this issue report.

@dc740
Copy link

dc740 commented Sep 27, 2022

ah, that's correct. Thank you @kisak-valve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests