tests: Run pytest with G_DEBUG=fatal-criticals #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that we crash out at any sign of undefined behaviour. This is the default for GLib's own GTest framework, but not for other test frameworks like pytest. Note that we cannot use fatal-warnings (which would be the default for GTest) because at least one test-case for the inputcapture portal emulates a faulty portal implementation, which libportal will log as a g_warning(). Signed-off-by: Simon McVittie <[email protected]>
|
CI failure is #187, I don't think that's related to what I changed in this PR. |
|
Actually it looks as though some of the tests might be triggering criticals under normal circumstances. I think that's a bug (the point of critical warnings is that they're ... critical) but it means we can't apply this just yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that we crash out at any sign of undefined behaviour. This is the default for GLib's own GTest framework, but not for other test frameworks like pytest.
Note that we cannot use fatal-warnings (which would be the default for GTest) because at least one test-case for the inputcapture portal emulates a faulty portal implementation, which libportal will log as a g_warning().