Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix condition to show encryption warning #755

Closed
wants to merge 1 commit into from
Closed

Fix condition to show encryption warning #755

wants to merge 1 commit into from

Conversation

salim-b
Copy link

@salim-b salim-b commented Sep 28, 2024

Although the official Flatpak documentation about XDG base directories states that

These environment variables are always set by flatpak and override any host values.

XDG_CONFIG_HOME can be unset, apparently?

This fixes #751 (hopefully).

Please note that I don't have much experience with Flatpak internals, so please thoroughly review this change.

`XDG_CONFIG_HOME` can be unset, apparently
@flathubbot
Copy link
Contributor

Started test build 150298

@flathubbot
Copy link
Contributor

Build 150298 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/133389/org.signal.Signal.flatpakref

@salim-b
Copy link
Author

salim-b commented Sep 28, 2024

Ok, I just realized I did a beginner mistake with

> flatpak run --command=echo org.signal.Signal "${XDG_CONFIG_HOME}/Signal"
/Signal

to test whether the env var is set for me. 🙈

Correct command:

> flatpak run --command=sh org.signal.Signal -c 'echo "${XDG_CONFIG_HOME}/Signal"'
/var/home/salim/.var/app/org.signal.Signal/config/Signal

So I dunno whether this PR still makes any sense.

@bbhtt
Copy link
Contributor

bbhtt commented Sep 29, 2024

Yea XDG_CONFIG_HOME can never be unset inside the sandbox. It's how Flatpak redirects it to ~/.var/app/$app-id/config instead of ~/.config

@bbhtt bbhtt closed this Sep 29, 2024
@salim-b salim-b deleted the patch-1 branch September 29, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signal is broken with Uncaught Exception: libsignal-client.node not found
3 participants