Skip to content

feat: use alloy SubmitBlockRequest #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

varun-doshi
Copy link

πŸ“ Summary

Use SubmitBlockRequest from alloy

πŸ’‘ Motivation and Context

Fixes #611

βœ… I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@Copilot Copilot AI review requested due to automatic review settings June 22, 2025 15:04
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the local SubmitBlockRequest type with the upstream SubmitBlockRequest from alloy_rpc_types_beacon, updating imports, client logic, and tests to use the external definition.

  • Import and consume alloy_rpc_types_beacon::relay::SubmitBlockRequest across crates
  • Remove the older local SubmitBlockRequest enum in rbuilder
  • Update tests, workspace dependencies, and import grouping to reflect the change

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/test-relay/src/validation_api_client.rs Import external SubmitBlockRequest and drop the old local import
crates/test-relay/src/relay.rs Use alloy_rpc_types_beacon SubmitBlockRequest and clean up imports
crates/test-relay/Cargo.toml Add alloy-rpc-types-beacon as a workspace dependency
crates/rbuilder/src/provider/mod.rs Consolidate RootHashError import into a single group
crates/rbuilder/src/mev_boost/submission.rs Remove local SubmitBlockRequest enum and import external type
crates/rbuilder/src/mev_boost/sign_payload.rs Switch to external SubmitBlockRequest in payload signing
crates/rbuilder/src/mev_boost/mod.rs Update RelayClient and tests to use the external SubmitBlockRequest
crates/rbuilder/src/live_builder/block_output/bid_observer_multiplexer.rs Switch to external SubmitBlockRequest import
crates/rbuilder/src/live_builder/block_output/bid_observer.rs Switch to external SubmitBlockRequest import
crates/bid-scraper/src/main.rs Reformat and group imports after migration
Comments suppressed due to low confidence (1)

crates/rbuilder/src/mev_boost/submission.rs:9

  • The imported SubmitBlockRequest from alloy_rpc_types_beacon is not used in this module; consider removing it to clean up unused imports.
};

@ZanCorDX
Copy link
Collaborator

It's failing lint checks.
Have you checked if you didn't leave unused structs (ElectraSubmitBlockRequest/CapellaSubmitBlockRequest/DenebSubmitBlockRequest)?
Are the tests updated?

@varun-doshi
Copy link
Author

Fixed lint and removed unused structs

make lint and make test run successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace SubmitBlockRequest with alloy's SubmitBlockRequest
2 participants