-
Notifications
You must be signed in to change notification settings - Fork 18
OpenTelemetry support #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0edf0b4
to
d6aba9d
Compare
e6a1d0a
to
7c1d189
Compare
255498d
to
6438e60
Compare
crates/op-rbuilder/src/launcher.rs
Outdated
@@ -0,0 +1,149 @@ | |||
use super::{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep this launcher on main.rs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, moved that to the main.rs
👌
crates/op-rbuilder/src/args/mod.rs
Outdated
@@ -70,13 +70,17 @@ impl CliExt for Cli { | |||
|
|||
/// Returns the type of builder implementation that the node is started with. | |||
/// Currently supports `Standard` and `Flashblocks` modes. | |||
fn builder_mode(&self) -> BuilderMode { | |||
fn builder_mode(&self) -> Option<BuilderMode> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we revert this change? We want to default for now to Standard if nothing else is set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, reverted and also squashed commits.
29e414e
to
68e83c9
Compare
68e83c9
to
dcadfb7
Compare
Adds OpenTelemetry support. To use it, activate
--feature=telemetry
. A feature gate is used to avoid integrating allopentelemetry
dependencies when they’re not needed.Key changes: since access to the tracing layer requires
CliApp
(which isCli
with additional configuration fields), the.configure()
method is used after parsing parameters.CliApp
also uses theLauncher
trait, allowing different types to configure the launch process. In our case, the launcher is implemented as a struct instead of a closure, and there's an emptyLauncher
for other (non-node
) commands, asreth
currently doesn’t allow omitting the launcher even when it’s not needed.To run, you can try:
Than open http://localhost:16686/
✅ I have completed the following steps:
make lint
make test