Skip to content

refactor(core): improve extensibility of Admin Pages #4200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025
Merged

refactor(core): improve extensibility of Admin Pages #4200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
126 changes: 80 additions & 46 deletions framework/core/js/src/admin/components/AppearancePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,57 +22,91 @@ export default class AppearancePage extends AdminPage {
}

content() {
return (
<>
<Form>
<FieldSet
className="AppearancePage-colors"
label={app.translator.trans('core.admin.appearance.colors_heading')}
description={app.translator.trans('core.admin.appearance.colors_text')}
>
{this.colorItems().toArray()}
</FieldSet>
</Form>

<Form>
<div className="Form-group">
<label>{app.translator.trans('core.admin.appearance.logo_heading')}</label>
<div className="helpText">{app.translator.trans('core.admin.appearance.logo_text')}</div>
<UploadImageButton name="logo" routePath="logo" value={app.data.settings.logo_path} url={app.forum.attribute('logoUrl')} />
</div>
return this.contentItems().toArray();
}

<div className="Form-group">
<label>{app.translator.trans('core.admin.appearance.favicon_heading')}</label>
<div className="helpText">{app.translator.trans('core.admin.appearance.favicon_text')}</div>
<UploadImageButton name="favicon" routePath="favicon" value={app.data.settings.favicon_path} url={app.forum.attribute('faviconUrl')} />
</div>
contentItems(): ItemList<Mithril.Children> {
const items = new ItemList<Mithril.Children>();

<div className="Form-group">
<label>{app.translator.trans('core.admin.appearance.custom_header_heading')}</label>
<div className="helpText">{app.translator.trans('core.admin.appearance.custom_header_text')}</div>
<Button className="Button" onclick={() => app.modal.show(EditCustomHeaderModal)}>
{app.translator.trans('core.admin.appearance.edit_header_button')}
</Button>
</div>
items.add(
'colors',
<Form>
<FieldSet
className="AppearancePage-colors"
label={app.translator.trans('core.admin.appearance.colors_heading')}
description={app.translator.trans('core.admin.appearance.colors_text')}
>
{this.colorItems().toArray()}
</FieldSet>
</Form>,
100
);

<div className="Form-group">
<label>{app.translator.trans('core.admin.appearance.custom_footer_heading')}</label>
<div className="helpText">{app.translator.trans('core.admin.appearance.custom_footer_text')}</div>
<Button className="Button" onclick={() => app.modal.show(EditCustomFooterModal)}>
{app.translator.trans('core.admin.appearance.edit_footer_button')}
</Button>
</div>
items.add('branding', <Form>{this.brandingItems().toArray()}</Form>, 90);

<div className="Form-group">
<label>{app.translator.trans('core.admin.appearance.custom_styles_heading')}</label>
<div className="helpText">{app.translator.trans('core.admin.appearance.custom_styles_text')}</div>
<Button className="Button" onclick={() => app.modal.show(EditCustomCssModal)}>
{app.translator.trans('core.admin.appearance.edit_css_button')}
</Button>
</div>
</Form>
</>
return items;
}

brandingItems(): ItemList<Mithril.Children> {
const items = new ItemList<Mithril.Children>();

items.add(
'logo',
<div className="Form-group">
<label>{app.translator.trans('core.admin.appearance.logo_heading')}</label>
<div className="helpText">{app.translator.trans('core.admin.appearance.logo_text')}</div>
<UploadImageButton name="logo" routePath="logo" value={app.data.settings.logo_path} url={app.forum.attribute('logoUrl')} />
</div>,
100
);

items.add(
'favicon',
<div className="Form-group">
<label>{app.translator.trans('core.admin.appearance.favicon_heading')}</label>
<div className="helpText">{app.translator.trans('core.admin.appearance.favicon_text')}</div>
<UploadImageButton name="favicon" routePath="favicon" value={app.data.settings.favicon_path} url={app.forum.attribute('faviconUrl')} />
</div>,
90
);

items.add(
'custom-header',
<div className="Form-group">
<label>{app.translator.trans('core.admin.appearance.custom_header_heading')}</label>
<div className="helpText">{app.translator.trans('core.admin.appearance.custom_header_text')}</div>
<Button className="Button" onclick={() => app.modal.show(EditCustomHeaderModal)}>
{app.translator.trans('core.admin.appearance.edit_header_button')}
</Button>
</div>,
80
);

items.add(
'custom-footer',
<div className="Form-group">
<label>{app.translator.trans('core.admin.appearance.custom_footer_heading')}</label>
<div className="helpText">{app.translator.trans('core.admin.appearance.custom_footer_text')}</div>
<Button className="Button" onclick={() => app.modal.show(EditCustomFooterModal)}>
{app.translator.trans('core.admin.appearance.edit_footer_button')}
</Button>
</div>,
70
);

items.add(
'custom-css',
<div className="Form-group">
<label>{app.translator.trans('core.admin.appearance.custom_styles_heading')}</label>
<div className="helpText">{app.translator.trans('core.admin.appearance.custom_styles_text')}</div>
<Button className="Button" onclick={() => app.modal.show(EditCustomCssModal)}>
{app.translator.trans('core.admin.appearance.edit_css_button')}
</Button>
</div>,
60
);

return items;
}

colorItems() {
Expand Down
Loading