[2.x] Codebase cleanup #4161
[2.x] Codebase cleanup #4161
Conversation
The method can either return `int` or `null`. There is no need to coalesce `null` into `null`.
No modifier = `public`, therefore I've added `public`.
Apparently PHPStan can't tell that the scope returns a model instance.
This method can't return `null` - we are throwing an exception if that's the case.
There was a problem hiding this comment.
That's is fantastic work, wow. Gigantic effort to go over all these files, did you do all of this manually or use some kind of refactoring utility?
I left a few remarks here and there, but overall I could not find any area where changes would negatively impact the application.
It was a completely manual effort, except for a few small things that were reported by my IDE itself. It certainly took me a bit of time, though, due to the size of the project, but I hope it was worth it. ✨ |
This PR aims to cleanup the codebase as well as utilize the latest technologies provided by PHP up to 8.2.
It's a pretty big one, but I've cut everything up into lots of commits, so if you don't like something, it's easily revertable.
There are no breaking changes here. Code style will have to be updated by StyleCI(?) - though, I wish there was php-cs-fixer or something like that included in the project, so I could properly adhere to the coding styles without thinking about it too much.