Skip to content

feat(cli): remove audit-list - #950

Open
davidfrigolet wants to merge 1 commit into
masterfrom
feat/remove-audit-list-cli
Open

feat(cli): remove audit-list#950
davidfrigolet wants to merge 1 commit into
masterfrom
feat/remove-audit-list-cli

Conversation

@davidfrigolet

Copy link
Copy Markdown
Contributor

feat(cli): remove audit-list

@bercianor bercianor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dieppa

dieppa commented Aug 16, 2026

Copy link
Copy Markdown
Member

There is a problem. We are removing two operationsÑ audit list and state.

``

@dieppa

dieppa commented Aug 16, 2026

Copy link
Copy Markdown
Member

There is a problem: With this change we are removing the audit list but also the audit state.

AuditListOperation.java:36-38

        List<AuditEntry> entries = args.isHistory()
                ? auditReader.getAuditHistory()
                : auditReader.getAuditSnapshot();

I know the trello ticket says to remove all those files, but it´s wrong...My mistake.

On the other hand, I am wondering if we should keep the audit ist also, but throwing a message that is an enterprise feature 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants