This repository was archived by the owner on Nov 16, 2024. It is now read-only.
Add Default Options for Color Picker Custom Element Class #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are experiencing an error when the custom element for the Color Picker is being cloned. It's a bit of a long story, but we are using Turbo Drive which calls
cloneNode
and we cannot easily prevent it. Since this is a custom element, I think it's a reasonable expectation it should support theHTMLElement
helpers.This error can be reproduced in a browser by selecting the
xy-color-picker
custom element in the respective "Elements" tab. Then going to the JavaScript "Console" and typing$0.cloneNode()
where$0
is a reference to that element (Chrome devtools).This errors because
cloneNode
is constructing the element without any arguments, which this constructor assumes.This PR addresses this error by defaulting
options
to{}
which avoidsoptions
being undefined.