This repository was archived by the owner on Nov 16, 2024. It is now read-only.
Add ability to cache user color choices based on config #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/index.js
Allow config to enable cached colors Concat cached colors with color collections
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @flaming-cl , sorry for the absence. I am resubmitting a PR to allow caching user color choices based on config as I tried ot do many months ago. I would like to address/seek some clarification from your final comment on #11 before the PR was closed.
The plugin will allow users to specify if they want the color caching to be enabled and the number of colors they want in their cache using allow
allowUserCachedColorsandnumberOfUserCachedColorsrespectively. These colors will be merged with the colorCollection allowing the user to have both. When the max cache size, obtained fromnumberOfUserCachedColorsin the config, is reached, only the cached colors are modified with the most resent placed at the top. In this way the replacement behavior is fairly predictable for users. Do let me know if you have any unanswered concerns.