Skip to content

Skip workload check if pid supplied to custom perf #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jmagnuson
Copy link

One of a number of potential solutions for #265, this PR simply adds awareness to custom perf supplying a PID set, to avoid the issues I mentioned in the ticket.

Related: #95

@djc
Copy link
Contributor

djc commented May 26, 2025

This PR seems to provide a way to run flamegraph without setting a workload, which seems like a convoluted way of enabling a time limit. How about we add an explicit --sleep (or something) option to flamegraph it self, instead?

(Sorry for the delay in responding.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants