Add support for cargo --profile #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Question: should we also deprecate / remove the |
No, let's keep that for now. |
djc
reviewed
Nov 2, 2022
src/bin/cargo-flamegraph.rs
Outdated
| cmd.arg("--release"); | ||
| if let Some(profile) = &opt.profile { | ||
| cmd.arg("--profile").arg(profile); | ||
| } else { |
There was a problem hiding this comment.
Would prefer to use else if directly here.
madadam
force-pushed
the
cargo-profile
branch
from
3ca8825 to
171509d
Compare
djc
reviewed
Nov 2, 2022
madadam
force-pushed
the
cargo-profile
branch
from
171509d to
2dcb414
Compare
djc
approved these changes
Nov 2, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #167