GH-3614: Fix identify_dynamic_embeddings
for composite DataPoints
#3659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3614
This PR fixes an issue where
identify_dynamic_embeddings
did not correctly detect dynamic embeddings (those withrequires_grad=True
) within compositeDataPoint
types likeDataPair
orSentence
with token embeddings.The logic has been refactored by:
_get_dynamic_embedding_names
and_get_all_embedding_names
) to theDataPoint
base class with default implementations.Sentence
,Span
,DataPair
,DataTriple
) to recursively check their constituent parts.identify_dynamic_embeddings
function intraining_utils.py
to use these helpers.This ensures all relevant dynamic embeddings are correctly identified across different
DataPoint
structures. Unit tests have been added intests/test_training_utils.py
to cover various scenarios and verify the fix.