Remove colorama depedency #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the task was to eliminate the colorama dependency. there is no need to reinvent the wheel. Consider to copy the code for the import and its dependencies to a colorama module in logprep. Then you should only fix the import. Please ensure to copy their license too. |
fabian-moessner
force-pushed
the
dev-rm-colorama-dependency
branch
from
302da57 to
858f250
Compare
|
When running locally |
|
fixed the changelog for better understanding and added the license as demanded by the author. |
ekneg54
approved these changes
Jan 29, 2025
|
and fixed black. they released a new version. we should reinstall the dev dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.