Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: fivetran-catfritz <[email protected]>
  • Loading branch information
fivetran-jamie and fivetran-catfritz authored Dec 17, 2024
1 parent 2412ef0 commit 21008b4
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
This release involves **breaking changes** and will require running a **full refresh**.

## Bug Fixes
- Adjusted the materialization of the `int_netsuite2__tran_with_converted_amounts` model **from incremental to [ephemeral](https://docs.getdbt.com/docs/build/materializations#ephemeral)**. There was a previous issue with the incremental strategy that could potentially produce duplicate records in certain situations ([PR #153](https://github.com/fivetran/dbt_netsuite/pull/153)).
- Our team has determined that the most sensible path forward is to remove the incremental logic for this model entirely, as its performance benefits have proved marginal and an ephemeral materialization will avoid any duplication issues.
- Adjusted the materialization of the `int_netsuite2__tran_with_converted_amounts` model **from incremental to [ephemeral](https://docs.getdbt.com/docs/build/materializations#ephemeral)** to resolve potential duplicate records in certain situations ([PR #153](https://github.com/fivetran/dbt_netsuite/pull/153)).
- This simplification minimizes duplication risk with marginal performance impact.
> This is a **Breaking Change**, as `int_netsuite2__tran_with_converted_amounts` will no longer materialize in the warehouse.
## Feature Updates
- Added two fields to the `netsuite2__balance_sheet` and `netsuite2__income_statement` models ([PR #151](https://github.com/fivetran/dbt_netsuite/pull/151)):
- Added two fields to the `netsuite2__balance_sheet` and `netsuite2__income_statement` models to support reporting on amounts in the functional currency alongside consolidated (`converted_amount`) results ([PR #151](https://github.com/fivetran/dbt_netsuite/pull/151)):
- `transaction_amount`
- `subsidiary_currency_symbol`
> This change **will require running a full refresh**, as we are adding new fields to incrementally materialized models.
Expand Down

0 comments on commit 21008b4

Please sign in to comment.