Update fork #1
Merged
Update fork #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relatedly, refactor `Locator.count/1`, used by `all/1`, to make use of the new `Frame.query_count/2`. Also, extract some `Locator` module docs which will soon find their way into guides.
...which in turn drives out the implementation of: - `Frame.drag_and_drop/4` - `Page.drag_and_drop/4`
This attempts to ensure the browser server has time to timeout and communicate that timeout to our GenServer, before the GenServer call times out Co-authored-by: German Velasco <[email protected]> Co-authored-by: Corey Innis <[email protected]>
Co-authored-by: Corey Innis <[email protected]> Co-authored-by: Ryan Spore <[email protected]>
Also, the `options` argument is always provided.
It's also used by `Frame`.
Also clarifies types for get_by_text options map, marks get_by_text_selector as public-but-internal, and adds a commented out function head for get_by_text to accept a regex as a reminder. Co-authored-by: German Velasco <[email protected]>
Co-authored-by: Ryan Spore <[email protected]>
Support page content
Karolk99
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.