gui: fix gossip votes in sankey #7014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jherrera-jump
force-pushed
the
jherrera/gui-fix-sankey
branch
3 times, most recently
from
bb220f2 to
b15faf3
Compare
Performance Measurements ⏳
|
mmcgee-jump
reviewed
Oct 31, 2025
mmcgee-jump
reviewed
Oct 31, 2025
| return; | ||
| } | ||
|
|
||
| if( FD_UNLIKELY( ctx->in_kind[ in_idx ]==IN_KIND_GOSSIP ) ) ctx->metrics.gossiped_votes_cnt++; |
There was a problem hiding this comment.
Isn't this metric also already tracked via. the link metrics?
There was a problem hiding this comment.
verify subscribes to gossip_out, which includes other frag types not just votes. They get filtered in the verify tile.
jherrera-jump
force-pushed
the
jherrera/gui-fix-sankey
branch
from
b15faf3 to
e103e6e
Compare
Performance Measurements ⏳
|
mmcgee-jump
approved these changes
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.