runtime: more verbose blockhash errors #6981
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibhatt-jumptrading
changed the title
Performance Measurements ⏳
|
ibhatt-jumptrading
force-pushed
the
ibhatt/verbose_blockhash_errors
branch
from
51a8bca to
93522fc
Compare
Performance Measurements ⏳
|
ibhatt-jumptrading
changed the title
mmcgee-jump
reviewed
Oct 29, 2025
src/disco/metrics/metrics.xml
Outdated
| <int value="15" name="InvalidLoadedAccountsDataSizeLimit" label="The compute budget program was invoked and set the loaded accounts data size to zero" /> | ||
| <int value="16" name="BlockhashNonceNotAdvanceable" label="The transaction references a nonce account that is not advanceable" /> | ||
| <int value="17" name="BlockhashNoAdvanceNonceInstr" label="The transaction does not have a valid blockhash and no advance nonce instruction was found" /> | ||
| <int value="18" name="BlockhashFailAdvanceNonceInstr" label="The transaction does not have a valid blockhash and the advance nonce instruction failed" /> |
There was a problem hiding this comment.
You mean it does have a valid blockhash?
There was a problem hiding this comment.
Suggested change
| <int value="18" name="BlockhashFailAdvanceNonceInstr" label="The transaction does not have a valid blockhash and the advance nonce instruction failed" /> | |
| <int value="18" name="NoneAdvanceFailed" label="The transaction does not have a valid blockhash and the advance nonce instruction failed" /> |
mmcgee-jump
reviewed
Oct 29, 2025
src/disco/metrics/metrics.xml
Outdated
| <int value="13" name="MaxLoadedAccountsDataSizeExceeded" label="The total account data size of the loaded accounts exceeds the consensus limit" /> | ||
| <int value="14" name="DuplicateInstruction" label="A compute budget program instruction was invoked more than once" /> | ||
| <int value="15" name="InvalidLoadedAccountsDataSizeLimit" label="The compute budget program was invoked and set the loaded accounts data size to zero" /> | ||
| <int value="16" name="BlockhashNonceNotAdvanceable" label="The transaction references a nonce account that is not advanceable" /> |
There was a problem hiding this comment.
Suggested change
| <int value="16" name="BlockhashNonceNotAdvanceable" label="The transaction references a nonce account that is not advanceable" /> | |
| <int value="16" name="NonceNotAdvanceable" label="The transaction references a nonce account that is not advanceable" /> |
And why would it be not advanceable?
There was a problem hiding this comment.
if next durable nonce == transactions's recent blockhash
mmcgee-jump
reviewed
Oct 29, 2025
src/disco/metrics/metrics.xml
Outdated
| <int value="14" name="DuplicateInstruction" label="A compute budget program instruction was invoked more than once" /> | ||
| <int value="15" name="InvalidLoadedAccountsDataSizeLimit" label="The compute budget program was invoked and set the loaded accounts data size to zero" /> | ||
| <int value="16" name="BlockhashNonceNotAdvanceable" label="The transaction references a nonce account that is not advanceable" /> | ||
| <int value="17" name="BlockhashNoAdvanceNonceInstr" label="The transaction does not have a valid blockhash and no advance nonce instruction was found" /> |
There was a problem hiding this comment.
I don't think you want this one? This should just map to BlockhashNotFound, as it's presumably not a nonce transaction
ibhatt-jumptrading
force-pushed
the
ibhatt/verbose_blockhash_errors
branch
from
93522fc to
c5ff611
Compare
Performance Measurements ⏳
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.