Skip to content

bank: clarify spad usage #6876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bank: clarify spad usage #6876

wants to merge 1 commit into from
+3 −17

Conversation

@mmcgee-jump
Copy link
Contributor

@mmcgee-jump mmcgee-jump commented Oct 23, 2025

No description provided.

@mmcgee-jump mmcgee-jump added this to the v1.0 milestone Oct 23, 2025
@mmcgee-jump mmcgee-jump enabled auto-merge October 23, 2025 17:01
@github-actions
Copy link

github-actions bot commented Oct 23, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.061254 s 0.050734 s -17.174% ✅
backtest mainnet-368528500-perf snapshot load 1.886 s 1.587 s -15.854% ✅
backtest mainnet-368528500-perf total elapsed 61.254409 s 50.734011 s -17.175% ✅
firedancer mem usage with mainnet.toml 1014.11 GiB 1014.11 GiB 0.000% ✅

ripatel-fd
ripatel-fd reviewed Oct 23, 2025
View reviewed changes
Copy link
Contributor

@ripatel-fd ripatel-fd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this construction worse ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ripatel-fd ripatel-fd ripatel-fd left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mmcgee-jump @ripatel-fd