configure: allow shmem mount path to be a symlinked directory #5680
+9
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmcgee-jump
reviewed
Jul 16, 2025
| @@ -338,9 +332,16 @@ check( config_t const * config ) { | |||
| PARTIALLY_CONFIGURED( "mount `%s` is on unrecognized device, expected `none`", mount_path[ i ] ); | |||
| } | |||
|
|
|||
| /* Resolve symlinks for mount_path as the mounts table has the resolved paths */ | |||
| char resolved_mount_path[ PATH_MAX ]; | |||
| if( FD_UNLIKELY( !realpath( mount_path[ i ], resolved_mount_path ) ) ) { | |||
There was a problem hiding this comment.
Use real syscall, e.g. readlink here instead of libc which might do other kinds of garbage underneath us. Also, failure to resolve is an FD_LOG_ERR, not a PARTIALLY_CONFIGURED (which is going to cause us to try blow away the directory).
|
Let's hold off on this for now |
|
A hack for a hack ... Or we just allow a user to specify a custom funk backing file? |
|
Seems like we don't need/want the ability to specify symlinks for mount paths. Closing for now. |
|
Thanks for sending this PR, it makes sense given what we already have on main. The underlying issue is the normalpages configure stage, which is a broken design (requiring different mount paths to map a single file) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.