quic: Improve loss detection with time threshold #5634
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhinvasara-jumptrading
force-pushed
the
akhin/quic_pto
branch
from
1757b69 to
5706cc8
Compare
No, we didn't. Was planning to let these changes soak on mainnet to monitor before merging, to see if we still see that. All after merging the service queue heap to avoid hiding bugs here. |
This reverts commit 543e6f0fb72451eb6294f249c135322e05b8a50d.
reset next_timeout in svc_schedule
fix retx timeout ticks/ns issue
prep schedule in gen_frames
CRIT if svc_timer_cnt != active_conn_cnt
schedule idle_timeout from last_activity, not now
test_quic_conformance: update for service heap
fix test_quic_keep_alive
fix rtt estimate
akhinvasara-jumptrading
force-pushed
the
akhin/quic_pto
branch
from
5706cc8 to
7265f80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very much a draft. Tests are yet unwritten. Intended to obtain feedback.
This PR improves the ability to detect losses, particulary with few packets on a connection. In addition to the packet skip threshold, it uses a time threshold to mark packets as lost.